From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEB2833D506 for ; Wed, 8 Apr 2026 01:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775612422; cv=none; b=CEOh/9zTCVabG3a08Hbs7Bhzw1bSYlIrfFNi/v9SmY1JYaJtCBibd6ijOXeTaEpOzy44PGXlTKgmrvFzeo9OMEZ84rufUWV6/Ax049gSQnsvfzSKbYjrYAS2TS+vH6+NE/hd6v/eiJ2lVqtr8xJGROKjhDO1aW5IgA2+TulLBTY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775612422; c=relaxed/simple; bh=dZHB03qDvyAIY6K858dGX/DOpQZ889+uybbGDndvFhE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZuNtY3yKweL9m91P4GK6qE7E03aJJ0RFuAAo/WmPSP+hDrzu43jW6CLSm3ga+z87wBTCgpJtDgWvmUSw7eWATtc2BZ1mLrl45j1UHZxw4wUyIAdnIjb/anzgxV+opbK8MgG+C50rFzBn7s9HgtT3LXDja/Y8iAGXdax5VdOSCR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=LtAd8FXU; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LtAd8FXU" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-c70c112cb61so3394821a12.0 for ; Tue, 07 Apr 2026 18:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1775612420; x=1776217220; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=NAIFlLQf8UMq9oLyp5tKNMTg+tYHTlufqxq0R1obwfw=; b=LtAd8FXUoTMw91l+QT9aBVvu1CBG6SH6CMiAhV0KzRRDGZ1DxLfve5u+Az+DA3qxeH gFzBiZ57sfOuZni2EuiI9BAD85iTz4WfnVR69ScmJKvtjiOT8m6C+e0KKT5W5zDNf2qt CjWouIySA+f2l927PxS1xAlcbC+6eqSlN+Epw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775612420; x=1776217220; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NAIFlLQf8UMq9oLyp5tKNMTg+tYHTlufqxq0R1obwfw=; b=iCL+7wxYkv1qtUMMZ3LCWVyT8MvJuecGilyOhnjUV+foRsgJ6G66vvHsPRuba+fa1C ImcIcYSzgTgVRkhob5tRZUK96FaL7Lhy/7AxXWwoDLz6Fj3dLl4ox//cxH3F5pdvM9MO FKrLpJ8avQPtjwsVGCR+CChV4RDNR1REIP7/aiWoR5taYlUjivnINePi9NjVH1Fibdzb mQacEea0R0tHq387ddcC6F9LmumXx8jyrLx+38teSCPJAwcRE91S1iKFHrJoRlkFXxpM /JByAyvUCmc+BYHFitXIKqR5lJzj8MsN5DqICGQ4CETvAIWY0oWoCSnaG6Sz6ntPL68c o8Ng== X-Forwarded-Encrypted: i=1; AJvYcCVrMQ5GodWX3RXC4DzSXsKBx2iNCXvod9MIxagaGwrGdWvgfzTAvYS6TbpHzP3SqyTCK4sj5U33SQE9cxA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywg2RotXBD4c+7CTXkGrnoJf4jR73cypPo0NbupKY23yKU+gdQb aMw0pGxBan3qAIyhj3tY0K4QhH0WyGzzzGD3LGX3ep12V5pjXUJ2FrO3S0hqli4KMw== X-Gm-Gg: AeBDietkawiJssDWyV3DQx8sfm7LiIIgyq8lYPRziKClqySJ2S9RndvoozpW2r78f+n QhIrTweD1HSvC1PKKVzhWoqKTd24yuZybl4RIO5xHtj3LNP5GYko5cbwy7+OPyn+U3Vd3cdmx00 2E8m2WZjlI5wqTSknfrCbPLcxuEEMqB19Mzvse9x1ysQ2oYCfAeXRnTpKRyG5y7nyCGzCFxMrvs H2+N37SF62XIxo4miPLBSQ1+44mYSuQiqqr3KQ5uN1sfoPpkkKcmwX12sHcZxcbxdHcgF7/MlNI Nk3FV3PXYLn4Z7PGrdnjF8agW2ugbvZJnvXkbh95PnXbS0mn7gdGLbeIn53RZgZzn+VHk0uIQYG VD8aWWt6GWyzTT/yERQuHroI3dEL/jVGd4+PPnYvSk8GYBuLALolX/leiMTzpnZr9WWrDU8b+52 kmAcmt7ZfQGfbc0vX7CijjD7xTMFNp4AIvmLqPvDELyc/uu5WXaLH68AiqRPwKzTM= X-Received: by 2002:a05:6a20:a111:b0:39f:59c8:f308 with SMTP id adf61e73a8af0-39f59c925abmr14048118637.27.1775612420330; Tue, 07 Apr 2026 18:40:20 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:f201:1700:5280:dbe9]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76c6563aacsm17266031a12.19.2026.04.07.18.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 18:40:19 -0700 (PDT) Date: Wed, 8 Apr 2026 10:40:16 +0900 From: Sergey Senozhatsky To: Andrew Stellman , Andrew Morton Cc: senozhatsky@chromium.org, minchan@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] zram: reject unrecognized type= values in recompress_store() Message-ID: References: <20260407153027.42425-1-astellman@stellman-greene.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260407153027.42425-1-astellman@stellman-greene.com> Adding Andrew on this: Message-ID: <20260407153027.42425-1-astellman@stellman-greene.com> On (26/04/07 11:30), Andrew Stellman wrote: [..] > recompress_store() parses the type= parameter with three if statements > checking for "idle", "huge", and "huge_idle". An unrecognized value > silently falls through with mode left at 0, causing the recompression > pass to run with no slot filter — processing all slots instead of the > intended subset. > > Add a !mode check after the type parsing block to return -EINVAL for > unrecognized values, consistent with the function's other parameter > validation. > > Suggested-by: Sergey Senozhatsky > Signed-off-by: Andrew Stellman > --- Reviewed-by: Sergey Senozhatsky Thank you.