From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BB663988FB for ; Wed, 8 Apr 2026 07:53:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775634824; cv=none; b=iCXN8r++gGjnBRsn/DVfj8K4VA+P6PPZxlH4S00DXSKrbwL11L21UnRkAtsDpNKf8YDC08DcVFu9FXLGdCOWADPw3m7zsr85labPDSLqPi+kYINDvU6DcWoV50Ov4cFMdZP+YRbkzaKw0SGJnkLNe4AHbyt7BPOotkSoI6lscOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775634824; c=relaxed/simple; bh=jeWCP70EDyJnr3muLjItO95xmCLvJ/emLa1MfJys3m4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n61K3jcifiMdJUjg2RIdEOyKqjVVXVOvVVz8wjb4wchYF0QgoXOWa6qCZsM9bNi+FRPFc64c40fNocu3WJDHkhksvi8RL/dCwMYONXdY6uncmRvzGXZUCvYrZeVdPJaKz0wkYWiGN5H2eKzSXoxLmzddJf5bTtsM9dqm4V1QceI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=aOTRmkWZ; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="aOTRmkWZ" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-48897fd88ebso45657145e9.2 for ; Wed, 08 Apr 2026 00:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1775634819; x=1776239619; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0nCZQ9hKi7CaAeBHIiwAmfmf5pDD+vpHncGueUYYsoQ=; b=aOTRmkWZpIDPHs1+JvJdb3E9C5TKKZvadQxZYtnE7/akQzoNvGUMLev6DD8exmmyc+ 5LzRYon3WR5zylcTC8Yz9XRNLSYXr8kvWuBG9TlY947kYWNqJia3VaT/a5X6oHiAJcV7 rZEiw0g7HKeeHUqZE1Tx2IjgQHov3mJOJrwrhqc5MeJAOVMvrTOGCi/3LOvMPPWj81zD 1vTgqNI0oVYQUCychTLAgLn01HnNH8JXVw5HeCiWv2C+71vbJ0+cKkjegCfuLb3yO1rx LeVQh6/5dkdzhBl+D0p7HxIJOhsMRikaJufR0NfEUOqK505fCR69S25ceQYtq8Nobg8L 0mGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775634819; x=1776239619; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0nCZQ9hKi7CaAeBHIiwAmfmf5pDD+vpHncGueUYYsoQ=; b=p/sjSWbXFOTVgDFhajRrOPEO87gR7rpX/7impHzIM448XoKbDMQ2I/thaLef9+yB3q LqUjprmPFhr7DLZuHTR+1EMYIQcOSpGQq3szKPA3s+PGxj/KMpTsphHgx3GAhekPoFa6 D93hdsT8kmJwDL40J7TamwXa4h+rE/tNkd97/+3s7rO1Db1zRGQNmJX9ETr5phjzjd3N 2hWrjQHfAWU0xFHTjxvNta3J1HiPz6MygKQlHpYsK/sfvyOtTYFbLJwEmmP4YR8mg0Tf wT5+2ZDzAALBuc3UkNQ4GrRvRGF94CIctjELZRGVboJyebfdpF+Ld1rzDR1+EgbVvXJM MRBg== X-Forwarded-Encrypted: i=1; AJvYcCWlRhuB4hBUhqb7YBO/vJPcL9MVT7ESLOfmRb3XST5qFHqMLLF8vTI7tKf/YP/k7kWGFBz3XscwlkR+qFg=@vger.kernel.org X-Gm-Message-State: AOJu0YyJDC7muq/tQd6aVQT+x4TaGsJB+pA2smYoKjZeKGeAUsawion2 NwR4v0n7JlDOMwvfKHRmMZDhVZz5ztHQJsvK6ik42KKYZHpC4HsDdzypAxj9SCXca7k= X-Gm-Gg: AeBDieu/kOVJjsjrScUUFFPZ/O05Wlx7AMXW9dXee2EkcrBbn1SGvt0vOXF4mYO9dV1 Et3bB4VMliJzgahJszzkZJDGriNs96ivIoUbIGfqrpcgdq73hTuIFXFsANL8O1HEu7SyMD5mfxD 7FDkUjk06YRO2t7HzWmdOj1aLMbav2HVcpD8424T7BpXOU3b1UP06pzhwpZ+1K75jqGipEq8gDO GFuTieVcbnK/BxxGsRf11wYEZh3sjOTq7g6r5D8yPThjSI51/hEGZxnlRDEd/enRUCzSvUNJlv/ 74PcK2hZ+0Y7TBDKdf8OWhHkue9M0xcrfyHiMyftFE7saklBhGcme/TTCIU84thRPuNmnpF1QTD LkOgHO7mdK34cqqYnFsJ+2swlayTZM1cmLd/MwGzAjF/XYVY8LBUgjJ0+Gapx+6331U/Z07LnCE FHs7K1vg1u01mZR3Q9ixCxyG4XPYLUpmDNz3mP X-Received: by 2002:a05:600c:810b:b0:488:c40b:c8a4 with SMTP id 5b1f17b1804b1-488c40bcac5mr36536885e9.1.1775634819356; Wed, 08 Apr 2026 00:53:39 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488c5dc6499sm12892245e9.30.2026.04.08.00.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 00:53:38 -0700 (PDT) Date: Wed, 8 Apr 2026 09:53:35 +0200 From: Petr Mladek To: Thorsten Blum Cc: Andrew Morton , Steven Rostedt , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib/vsprintf: use bool for local decode variable Message-ID: References: <20260407181835.1053072-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407181835.1053072-2-thorsten.blum@linux.dev> On Tue 2026-04-07 20:18:36, Thorsten Blum wrote: > The local variable 'decode' is only used as a boolean value - change its > data type from int to bool accordingly. > > --- a/lib/vsprintf.c > +++ b/lib/vsprintf.c > @@ -1107,7 +1107,7 @@ char *resource_string(char *buf, char *end, struct resource *res, > 2*RSRC_BUF_SIZE + FLAG_BUF_SIZE + RAW_BUF_SIZE)]; > > char *p = sym, *pend = sym + sizeof(sym); > - int decode = (fmt[0] == 'R') ? 1 : 0; > + bool decode = fmt[0] == 'R'; > const struct printf_spec *specp; > > if (check_pointer(&buf, end, res, spec)) > @@ -1132,7 +1132,7 @@ char *resource_string(char *buf, char *end, struct resource *res, > } else { > p = string_nocheck(p, pend, "??? ", str_spec); > specp = &mem_spec; > - decode = 0; > + decode = false; > } > if (decode && res->flags & IORESOURCE_UNSET) { > p = string_nocheck(p, pend, "size ", str_spec); I have mixed feeling about this patch. I agree that it might slightly improve code readability. But cosmetic changes are usually about personal preferences and often just pollute code history. IMHO, this is really just about "code readability" vs "code history pollution" problem. I believe that compilers would handle both variants the same way. As I said, I agree that this this slightly improves the code readability and it is trivial. So I am going to wait few more days and take this patch unless there is a strong push back from others. Reviewed-by: Petr Mladek Best Regards, Petr