From: Jarkko Sakkinen <jarkko@kernel.org>
To: Arun Menon <armenon@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
Jason Gunthorpe <jgg@ziepe.ca>, Peter Huewe <peterhuewe@gmx.de>
Subject: Re: [RFC 2/4] tpm_crb: Add new wrapper function to invoke start method
Date: Wed, 8 Apr 2026 11:36:06 +0300 [thread overview]
Message-ID: <adYTdmCKferDsu4_@kernel.org> (raw)
In-Reply-To: <acKG6EQ_tXO8eqfj@fedora>
On Tue, Mar 24, 2026 at 06:13:20PM +0530, Arun Menon wrote:
>
> On Tue, Mar 24, 2026 at 12:42:19PM +0200, Jarkko Sakkinen wrote:
> > On Tue, Mar 24, 2026 at 12:48:01PM +0530, Arun Menon wrote:
> > > - Extract start invocation code into a separate function called
> > > crb_trigger_tpm. This will be helpful in repeatedly calling the
> > > start method with different bits set to toggle between start,
> > > nextChunk or crbRspRetry behaviours.
> > > - Based on the bit set, we signal the TPM to consume
> > > contents of the command/response buffer.
> > > - No functional change intended.
> >
> > Please write a proper commit message, which is not a task list.
>
> Yes, I shall do that. Thank you for taking a look.
Yeah, and now is good time to improve cosmetic details like this.
I rather take closer look at code when I can run it as I'm not LLM
coding agent, I need to run to understand cannot hallucinate it :-)
BR, Jarkko
next prev parent reply other threads:[~2026-04-08 8:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 7:17 [RFC 0/4] tpm_crb: Add command and response buffer chunking support Arun Menon
2026-03-24 7:18 ` [RFC 1/4] tpm_crb: Add definition of TPM CRB chunking fields Arun Menon
2026-03-24 7:18 ` [RFC 2/4] tpm_crb: Add new wrapper function to invoke start method Arun Menon
2026-03-24 10:42 ` Jarkko Sakkinen
2026-03-24 12:43 ` Arun Menon
2026-04-08 8:36 ` Jarkko Sakkinen [this message]
2026-03-24 7:18 ` [RFC 3/4] tpm_crb: Implement command and response chunking logic Arun Menon
2026-03-24 10:45 ` Jarkko Sakkinen
2026-03-24 12:46 ` Arun Menon
2026-03-24 7:18 ` [RFC 4/4] tpm: Increase TPM_BUFSIZE to 64kB for chunking support Arun Menon
2026-03-24 10:41 ` [RFC 0/4] tpm_crb: Add command and response buffer " Jarkko Sakkinen
2026-03-24 12:41 ` Arun Menon
2026-04-08 8:34 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adYTdmCKferDsu4_@kernel.org \
--to=jarkko@kernel.org \
--cc=armenon@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox