From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Thorsten Blum <thorsten.blum@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/vsprintf: use bool for local decode variable
Date: Wed, 8 Apr 2026 16:18:04 +0300 [thread overview]
Message-ID: <adZVjCDjAeff2EQ3@ashevche-desk.local> (raw)
In-Reply-To: <adYJfwi-K-8ZB5DB@pathway.suse.cz>
On Wed, Apr 08, 2026 at 09:53:35AM +0200, Petr Mladek wrote:
> On Tue 2026-04-07 20:18:36, Thorsten Blum wrote:
...
> I have mixed feeling about this patch
Same here.
> I agree that it might slightly
> improve code readability. But cosmetic changes are usually about
> personal preferences and often just pollute code history.
>
> IMHO, this is really just about "code readability" vs "code history
> pollution" problem. I believe that compilers would handle both variants
> the same way.
>
> As I said, I agree that this this slightly improves the code
> readability and it is trivial. So I am going to wait few more
> days and take this patch unless there is a strong push back
> from others.
Up to you, no pushback from me, and no tag as well. Personally
I consider it's a churn, but we have tons of a such in the kernel
(I mean int as boolean cases).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-08 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 18:18 [PATCH] lib/vsprintf: use bool for local decode variable Thorsten Blum
2026-04-07 19:29 ` David Laight
2026-04-08 7:53 ` Petr Mladek
2026-04-08 13:18 ` Andy Shevchenko [this message]
2026-04-14 14:25 ` Petr Mladek
2026-04-14 15:36 ` Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adZVjCDjAeff2EQ3@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox