Re: [PATCH v2 1/1] mtd: cfi_cmdset_0001: Factor out do_write_buffer_locked() to reduce stack frame

Miquel Raynal
2026-02-05T08:52:01Z

Hi Andy,

On 04/02/2026 at 23:12:00 +02, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Wed, Feb 04, 2026 at 02:25:27AM +0100, Andy Shevchenko wrote:
>> Compiler is not happy about used stack frame:
>>
>> drivers/mtd/chips/cfi_cmdset_0001.c: In function 'do_write_buffer':
>> drivers/mtd/chips/cfi_cmdset_0001.c:1887:1: error: the frame size of 1296 bytes is larger than 1280 bytes [-Werror=frame-larger-than=]
>>
>> Fix this by factoring out do_write_buffer_locked().
>
> My gosh, I already sent a v2 earlier and there were some replies,
> I need to check...

I'm not sure I get what you mean here? I got no reply (in my inbox) to
your v2. I am letting a bit of time for Vignesh to take a look, but I
know he's busy so I might take it nevertheless by the end of the week as
we are approaching the merge window.

Cheers,
Miquèl