Re: [PATCH v2 1/1] mtd: cfi_cmdset_0001: Factor out do_write_buffer_locked() to reduce stack frame

Andy Shevchenko
2026-04-08T11:27:47Z

On Wed, Apr 08, 2026 at 08:35:52AM +0200, Lukas Wunner wrote:
> On Wed, Feb 04, 2026 at 02:25:27AM +0100, Andy Shevchenko wrote:
> > Compiler is not happy about used stack frame:
> >
> > drivers/mtd/chips/cfi_cmdset_0001.c: In function 'do_write_buffer':
> > drivers/mtd/chips/cfi_cmdset_0001.c:1887:1: error: the frame size of 1296 bytes is larger than 1280 bytes [-Werror=frame-larger-than=]
> >
> > Fix this by factoring out do_write_buffer_locked().
>
> FWIW, the issue only occurs with CONFIG_KASAN_STACK=y, so an alternative
> to refactoring the function is to disable KASAN for this particular file:

I would like to avoid such big hammers.

Somehow I lost the track of this patch, I need to find it locally and check
the status, I will come up with updated one once I found the latest version.

--
With Best Regards,
Andy Shevchenko