From: Dan Carpenter <error27@gmail.com>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: gregkh@linuxfoundation.org, dan.carpenter@linaro.org,
ethantidmore@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/6] staging: rtl8723bs: convert xmit init path to errno
Date: Wed, 8 Apr 2026 16:48:06 +0300 [thread overview]
Message-ID: <adZclv5nv8W1cXNF@stanley.mountain> (raw)
In-Reply-To: <20260408111314.19329-1-dennylin0707@gmail.com>
On Wed, Apr 08, 2026 at 11:13:08AM +0000, Hungyu Lin wrote:
> Convert the xmit initialization path to use standard kernel
> return conventions: 0 on success and negative errno on failure.
>
> This replaces the use of _SUCCESS/_FAIL with proper error
> codes and improves error propagation.
>
> The changes are split into smaller patches following review
> feedback from Dan Carpenter, converting one function at a time
> to make the series easier to review.
>
> v5:
> - Fix trailing whitespace in os_intfs.c
>
> v4:
> - Split into a series of smaller patches as suggested by Dan Carpenter
> - Convert functions step by step to improve reviewability
> - Ensure each patch builds independently
>
Thanks!
Reviewed-by: Dan Carpenter <error27@gmail.com>
regards,
dan carpenter
prev parent reply other threads:[~2026-04-08 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 11:13 [PATCH v5 0/6] staging: rtl8723bs: convert xmit init path to errno Hungyu Lin
2026-04-08 11:13 ` [PATCH v5 1/6] staging: rtl8723bs: simplify _rtw_init_xmit_priv control flow Hungyu Lin
2026-04-08 11:13 ` [PATCH v5 2/6] staging: rtl8723bs: make rtw_alloc_hwxmits static Hungyu Lin
2026-04-08 11:13 ` [PATCH v5 3/6] staging: rtl8723bs: convert rtw_alloc_hwxmits to return errno Hungyu Lin
2026-04-08 11:13 ` [PATCH v5 4/6] staging: rtl8723bs: move rtw_os_xmit_resource_alloc to rtw_xmit.c Hungyu Lin
2026-04-08 11:13 ` [PATCH v5 5/6] staging: rtl8723bs: convert rtw_os_xmit_resource_alloc to return errno Hungyu Lin
2026-04-08 11:13 ` [PATCH v5 6/6] staging: rtl8723bs: convert _rtw_init_xmit_priv " Hungyu Lin
2026-04-08 13:48 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adZclv5nv8W1cXNF@stanley.mountain \
--to=error27@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=dennylin0707@gmail.com \
--cc=ethantidmore@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox