From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5AE43B8938 for ; Wed, 8 Apr 2026 13:48:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775656095; cv=none; b=SDBcOoGGoE4RJRR84tkJW8XxL3R8Q76xBLAjxlDidiIxWqRE+WvTF+WOTUOr2AuU+6pRCLFQkedOJ6Xino3V+3vZ8hN48cAsEOiboKlb81gIkV/GPIVJOnWKu8lnSP9+p4Mmt1DOvwWeQ/HtDsv08FR0+WcoL2LKLftCqUxEtow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775656095; c=relaxed/simple; bh=pmLg8Ynrnzn99i1OBfyJlnnntDwHsU23+NqD9dTM3jk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=inIuqZXhpRtx1AFj9Mx8ARoNuYlhzymYOUa+eprf31qda3y+V8eAumlc1qSZS1RdcHXxWq5+ZPq4+popSQokuR4JRnSQO2VxoWU5Pz5VZJad6m/5PgiuNwlcLZTd7nQKqvt5chhUm+7p6uzGzyiNGFUU/o4aQgINlmioJlVLCjE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WJyP7r8N; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WJyP7r8N" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-2c15849aa2cso8649802eec.0 for ; Wed, 08 Apr 2026 06:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775656093; x=1776260893; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VHAUSkDykTSZ19gg6L6AVzq+02nkCv+puFTeLx+hHC0=; b=WJyP7r8NiKVbNYcr+/KYvdxVQ72KgRet9iaQtmAcXBPGSygU7Su45mtyKk9cQ42PuJ joZeDpaj+FB1luenU6T1MFDF7I+z3bDjAJQbaHJDRGgB32nNMUfxcAhDYGMCX+XTa9ra kKtZYwR0vbUEJRetEQfUFcKR/edKSuYrnyY4Nd1EW8D2Gee2LC68pa+XO+tWFzPwxWt2 tt8MEQLOcanoQ3SyEkcRbip7qG2YN6BvBeuzzfv+7tzCDlxiyxZluNkV0qnsnvv4zc8n z3kFh64eqhFAOHAmqB9+sV7mrX/MnUfK0G/AehBQia+UW6M3Vcs7PUj6hC5ru8hsZ6EB rxLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775656093; x=1776260893; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VHAUSkDykTSZ19gg6L6AVzq+02nkCv+puFTeLx+hHC0=; b=Y/4ond6Vx5R5l+wloz1bWsWkyGoEJbNfTKEZBkUjkiOTO8Gx+2Vi6+tZzynXl6fNrJ jBnlorA+XSj7oQ7MFKwgQ1bZVqnpCjxJK1r130r+cEsnw9tvRqH9OG9voWQF2iZA/P4S d7OVb5700W8isZtInDvp8bpOYsqqrshft2vNu7aUq+/6stRal50B91UI8YRGtKsI90Oq O3XfpO7Wn6Lut6SrbncBBlqAj/e11AyfDa5kagRFMRLP4Q7D+wC3V3BBagTVqcPe7PGL T2Dkh/hlGdTcvpYIDpFIAR2Y6YTy2ILoMtr++koqcTqtVQO+itUXOD9vKLiYpfYhhWkS S/Lg== X-Forwarded-Encrypted: i=1; AJvYcCUXmEs543468EfY5PuIdw2oRBE7xXCsc5+4b2DsCNH8exwjeM5QV16vdQlnKRrKoggcUMYKYTeVE+sU/Jw=@vger.kernel.org X-Gm-Message-State: AOJu0YwuzomKJrDU30S9CDSaso5mLM3osbA0wtIzIZ4vEsRI1ndt82TK w+tEP2kxeKzGHuEDKhCNeBXd+nt3HW5Ze50HdgpBDa4PzBQUKPVyavUJUjep9KUuBiI= X-Gm-Gg: AeBDietun1aWOFln7A5fKMV7JZyYyEjZrl+MvAf+V7eC+nLjIIBXsGCVzlx9JtDEHMG 9QaWm7fNOfFToiuorqEcB9fygHc3ZGLZUKI0w8pKj16tZyP7nEmBXRZ1Vb35wNXxYJ3Fx1GdrYV 0TwR+iy9469owTy9tNEKc5HnMkK7M+q93ZwIMZHs3j1d5qzTYnwHNtz6J0nnshpW1yE/7KZ+KBf HuyYRQAGbIdp+tt6HLPMbHPVDi8BRCr/fVT+A11Y6xRG5te1ADQvZ5B3pSDqfatA3py3s03pIsb CS/5SR3yhLNm9T95qO3TLaUnqUkwrpP6KydbWk10ubI19AKvzQfADXOX5OcucOwvWFpRmNjOZ2p bJqUkpOBZsaz7xp0GteNjOde+nfeYcMmQ/CvvGuwsRpVhH9rEHESzS0pJ74VXudL3A+N2m0UHF7 R1DhJ2MsWogUgPjSPS X-Received: by 2002:a05:7301:6093:b0:2c7:3a7:c7a6 with SMTP id 5a478bee46e88-2cbfa2d8089mr11047477eec.13.1775656092967; Wed, 08 Apr 2026 06:48:12 -0700 (PDT) Received: from localhost ([172.216.11.43]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ce39d13decsm13684434eec.8.2026.04.08.06.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 06:48:12 -0700 (PDT) Date: Wed, 8 Apr 2026 16:48:06 +0300 From: Dan Carpenter To: Hungyu Lin Cc: gregkh@linuxfoundation.org, dan.carpenter@linaro.org, ethantidmore@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/6] staging: rtl8723bs: convert xmit init path to errno Message-ID: References: <20260408111314.19329-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260408111314.19329-1-dennylin0707@gmail.com> On Wed, Apr 08, 2026 at 11:13:08AM +0000, Hungyu Lin wrote: > Convert the xmit initialization path to use standard kernel > return conventions: 0 on success and negative errno on failure. > > This replaces the use of _SUCCESS/_FAIL with proper error > codes and improves error propagation. > > The changes are split into smaller patches following review > feedback from Dan Carpenter, converting one function at a time > to make the series easier to review. > > v5: > - Fix trailing whitespace in os_intfs.c > > v4: > - Split into a series of smaller patches as suggested by Dan Carpenter > - Convert functions step by step to improve reviewability > - Ensure each patch builds independently > Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter