From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D53CD24A078 for ; Wed, 15 Apr 2026 20:49:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776286156; cv=none; b=qWGmBsTtuje1dHOq23FACOOjpjUSWEGDdPYBUy4DBjUYzmfL/mxvSkEjuBOIslVRwVhWn9JQTpECv7ZDlyT1X/FI/hy4Pm4xTBtVsy9oEjWRL+e0JsnE3TdbCULhR0IJe2BFHZZvQlCyxh0hoMkcxSGc5NqEMgvW/jE6fH80HjY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776286156; c=relaxed/simple; bh=87ZnNVw54Ect91QfjKmfKw5fIH72SgBecZYAMYQC1tk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ElP4Q+UR95BLPjGtAwP8J61hJWLGvr5RyrOb7UdAI0ZNLWRPQIk67hfxCU/4yFsZRSVormtnYTaYLwOiGN0r9pcyNEARbCgilgnv3nkMpp4He+11LYtkAEleSXFyjTU4qrmZbH6BOpAZ8ku4Kas+P0715YF0Og5Znlrnot5ynmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=dJTjLu05; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dJTjLu05" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-488a62b7372so26745e9.1 for ; Wed, 15 Apr 2026 13:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776286153; x=1776890953; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8aVP/1KbfVghlSudtY96ZNkOwitIzJUOvnr4jYxspHw=; b=dJTjLu05SWCUKMxOsE59ycWee331hQILBlxzhwAggrbr9kWPEmzIB/e9xX/N6mQJfx wQlSciVK+vhdCSyHoOmcorqzcTUWKbUjaRUBVJyhfaw9IcFy+qHwXdxtWVm6yXzj9ERB pvKVNM+MVShOa87oc5RoVVPHOrE1rfBGc6WOO3gUx16Bm0EjSlpNyBsEupADk0WVpZkW gcjdlHT7aZFrrUORICAQN0Ggx3B69yV+tYM7+YZCv//J+qfOaA94klgX/iLs2chbegig WvTCaM5NGfDOe1vDjH/dCXvF/2AlkPhGQEXNwm+hbjh65Azx68HKfQBXPiv30t/GrnpO Ch5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776286153; x=1776890953; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8aVP/1KbfVghlSudtY96ZNkOwitIzJUOvnr4jYxspHw=; b=cLAVLOOWjEjJV5A0ZL6u4wT+2iF3aTdvZh/9OyREez0Zuc7GQKzD8qj6ZcW17Z2kAc sT64aa4ugoB+bCESpJmViENlfr84OP52xguNJmRIm0ceLpFcK4O9qyWMvRPKKeH2X6aE 7ADoRoeAspogonqzFNywNFYWjTZW0b6tm6QHLZyTUpC76klcalDh33E2RIlQE3NVF5aj 4kkkoWhqw85Ifj+jNw693bPbacXaaaplnF8Q0Yg98zjgE4B8AUGbDx64vYcI0SsDhS/a 7I6FkkbRHiN3uEAcDHt5PfPrewsDdQplNqeywohpAD+MjTSI/SkzRVrbv3s0qugQDvo9 P3QA== X-Forwarded-Encrypted: i=1; AFNElJ91koAgZ/UkxFULXEMlqA2eXYG9eFrlVI/xY8qpk2bXJNj/haKDH+YFra1c1KxzEJHCQMRisgs+dyjpobM=@vger.kernel.org X-Gm-Message-State: AOJu0YzM1amcdB6sb3NsJBwEqqQVo3hars+AL9cGZyiVimDdiEg3G27X fpQBtVpD75LWeBgNSls7Q//vGZDvhhqx0WB1/iaXQDAqe0DnD+rGMYAKqomY7wSorQ== X-Gm-Gg: AeBDievVZyto+23q6NRyLAHOLZ+jDMODVwnhP5rba01q0lf2OjM79CAIOcebkGRDT54 mO/7MFH4sRc7R0rfiVkVmKWoVeqTY7fCEmv2SSNhDFcjRyO4q9KTUy6CO4gQ2QOeNtx1rjilYLH IlhT28qAZZKm+ICbxuRKRnvTmIjj4H479GzBkkipiBxtaB6dN+JDsyzdEMCxzLOLmT4vfMmGPvb p/wcs3H4+zdzKGr6AZn6c/rkLd939k7Qg7215poUtcOxa0/xIb5sN3jKnYeaOdlVNC8BbRjA5lu SKppWt0d3x0f1uJNo9Lwu1tHkGvxXEAz0k96D+niiy6XtaGBSgjRAMiF/Lr5BkSUMTUJ/vHSoJ7 TPV3v3zhDK40yoygSaRb7Y06jJGRMXInOEHORkL30H0KV5ahj3wJFz3n+Vk4CZcCrPyvrW8BxDm PCWOX/svC0Gm5ioWJPkYIwAa/HvpboJMAigK4wK87aZHxHBrRBwFXAywo5aCmspyEXHquE0Jeqm 6pkZg== X-Received: by 2002:a05:600c:22d4:b0:480:683f:743d with SMTP id 5b1f17b1804b1-488f4ae929dmr170495e9.14.1776286152833; Wed, 15 Apr 2026 13:49:12 -0700 (PDT) Received: from google.com (8.181.38.34.bc.googleusercontent.com. [34.38.181.8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488ede1df12sm351296065e9.4.2026.04.15.13.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 13:49:12 -0700 (PDT) Date: Wed, 15 Apr 2026 20:49:08 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, robin.murphy@arm.com, m.szyprowski@samsung.com, will@kernel.org, maz@kernel.org, suzuki.poulose@arm.com, catalin.marinas@arm.com, jiri@resnulli.us, aneesh.kumar@kernel.org Subject: Re: [RFC PATCH v3 2/5] dma-mapping: Move encryption in __dma_direct_free_pages() Message-ID: References: <20260408194750.2280873-1-smostafa@google.com> <20260408194750.2280873-3-smostafa@google.com> <20260410174553.GD2551565@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260410174553.GD2551565@ziepe.ca> On Fri, Apr 10, 2026 at 02:45:53PM -0300, Jason Gunthorpe wrote: > On Wed, Apr 08, 2026 at 07:47:39PM +0000, Mostafa Saleh wrote: > > In the next patches, we will need to avoid encrypting memory allocated > > from SWIOTLB, so instead of calling dma_set_encrypted() before > > __dma_direct_free_pages(), call it inside, conditional on the memory > > state passed to the function. > > > > Signed-off-by: Mostafa Saleh > > --- > > kernel/dma/direct.c | 22 +++++++++++----------- > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > > index 6efb5973fbd3..ce74f213ec40 100644 > > --- a/kernel/dma/direct.c > > +++ b/kernel/dma/direct.c > > @@ -97,8 +97,11 @@ static int dma_set_encrypted(struct device *dev, void *vaddr, size_t size) > > } > > > > static void __dma_direct_free_pages(struct device *dev, struct page *page, > > - size_t size) > > + size_t size, bool encrypt) > > { > > This feels like it would be nicer if it could be the > swiotlb_page_state instead of a bool, maybe the enum needs a different > name. I am not sure I get this, at this point the swiotlb stuff is not introduced yet, I try to refactor the free path to make is easier to modify next, the bool encrypt here is typically set to false from the error path. I can replace that with a wrapper doing the encryption and calling the free function. Thanks, Mostafa > > Jason