From: Roland Dreier <rdreier@cisco.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: "Barnes\, Jesse" <jesse.barnes@intel.com>,
Matthew Wilcox <matthew@wil.cx>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
general@lists.openfabrics.org, linux-kernel@vger.kernel.org
Subject: Re: mthca double free irqs
Date: Fri, 12 Jun 2009 21:30:34 -0700 [thread overview]
Message-ID: <ada1vpozrf9.fsf@cisco.com> (raw)
In-Reply-To: <86802c440906111945n2a42dc94mf08bd2b1a252842f@mail.gmail.com> (Yinghai Lu's message of "Thu, 11 Jun 2009 19:45:21 -0700")
Something like this should help -- can you verify this fixes the double
free of irq?
drivers/infiniband/hw/mthca/mthca_eq.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/mthca/mthca_eq.c b/drivers/infiniband/hw/mthca/mthca_eq.c
index 28f0e0c..90e4e45 100644
--- a/drivers/infiniband/hw/mthca/mthca_eq.c
+++ b/drivers/infiniband/hw/mthca/mthca_eq.c
@@ -641,9 +641,11 @@ static void mthca_free_irqs(struct mthca_dev *dev)
if (dev->eq_table.have_irq)
free_irq(dev->pdev->irq, dev);
for (i = 0; i < MTHCA_NUM_EQ; ++i)
- if (dev->eq_table.eq[i].have_irq)
+ if (dev->eq_table.eq[i].have_irq) {
free_irq(dev->eq_table.eq[i].msi_x_vector,
dev->eq_table.eq + i);
+ dev->eq_table.eq[i].have_irq = 0;
+ }
}
static int mthca_map_reg(struct mthca_dev *dev,
next prev parent reply other threads:[~2009-06-13 4:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 2:45 mthca double free irqs Yinghai Lu
2009-06-12 14:31 ` Roland Dreier
2009-06-12 17:22 ` Yinghai Lu
2009-06-12 14:33 ` Roland Dreier
2009-06-12 15:50 ` Jesse Barnes
2009-06-12 16:25 ` Roland Dreier
2009-06-12 16:26 ` Roland Dreier
2009-06-13 4:30 ` Roland Dreier [this message]
2009-06-13 19:28 ` Yinghai Lu
2009-06-13 22:04 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada1vpozrf9.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=general@lists.openfabrics.org \
--cc=jesse.barnes@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox