public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: davej@redhat.com, cpufreq@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] cpufreq: Remove KERN_ERR output if nForce2 chipset not found
Date: Fri, 06 Mar 2009 12:55:56 -0800	[thread overview]
Message-ID: <ada3adqid5v.fsf@cisco.com> (raw)

Distribution kernels are building cpufreq drivers into the kernel to get
faster boot; if the nForce2 driver is built in, then on systems that are
not supported by the driver (ie nearly all current systems), the message

    cpufreq: No nForce2 chipset.

is printed at the KERN_ERR level, which means it goes to the console
even if quiet boot is turned on.

The best way to handle this is just to delete the message, since the
likelihood of it ever being of any use to anyone is very low, and other
cpufreq drivers don't print anything if no matching hardware is found.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
 arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c b/arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c
index 965ea52..055fca3 100644
--- a/arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c
+++ b/arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c
@@ -419,10 +419,8 @@ static int __init nforce2_init(void)
 	/* TODO: do we need to detect the processor? */
 
 	/* detect chipset */
-	if (nforce2_detect_chipset()) {
-		printk(KERN_ERR "cpufreq: No nForce2 chipset.\n");
+	if (nforce2_detect_chipset())
 		return -ENODEV;
-	}
 
 	return cpufreq_register_driver(&nforce2_driver);
 }

             reply	other threads:[~2009-03-06 20:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-06 20:55 Roland Dreier [this message]
2009-03-06 21:06 ` [PATCH] cpufreq: Remove KERN_ERR output if nForce2 chipset not found Jarod Wilson
2009-03-06 21:51   ` Roland Dreier
2009-03-06 22:01     ` Jarod Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada3adqid5v.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=cpufreq@vger.kernel.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox