public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org,
	MUNEDA Takahiro <muneda.takahiro@jp.fujitsu.com>,
	Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>,
	Kristen Carlson Accardi <kristen.c.accardi@intel.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Andrew Morton <akpm@osdl.org>,
	shemminger@osdl.org, ak@suse.de, davem@davemloft.net
Subject: Re: The change "PCI: assign ioapic resource at hotplug" breaks my system
Date: Tue, 03 Oct 2006 10:51:55 -0700	[thread overview]
Message-ID: <ada3ba5s2x0.fsf@cisco.com> (raw)
In-Reply-To: <45225876.1080705@jp.fujitsu.com> (Kenji Kaneshige's message of "Tue, 03 Oct 2006 21:32:54 +0900")

    Kenji> The cause of this problem might be an wrong assumption that
    Kenji> the 'start' member of resource structure for ioapic device
    Kenji> has non-zero value if the resources are assigned by
    Kenji> firmware. The 'start' member of ioapic device seems not to
    Kenji> be set even though the resources were actually assigned to
    Kenji> ioapic devices by firmware.

    Kenji> I made a patch to fix this problem against
    Kenji> 2.6.18-git18. This patch checks command register instead of
    Kenji> checking 'start' member to see if the ioapic is already
    Kenji> enabled by firmware. Unfortunately, I don't have any system
    Kenji> to reproduce this problem. Could you please try it and let
    Kenji> me know whether the problem is fixed? If the patch below
    Kenji> fixes the problem, I'll resend it with description and
    Kenji> Signed-off-by.

Yes, applying this patch makes everything work on the same SuperMicro
motherboard that breaks with Linus's current tree.  Assuming this
doesn't break anything else, I think this should go upstream.

Thanks,
  Roland

  reply	other threads:[~2006-10-03 17:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-02 17:05 The change "PCI: assign ioapic resource at hotplug" breaks my system Roland Dreier
2006-10-02 17:28 ` Roland Dreier
2006-10-03 12:32 ` Kenji Kaneshige
2006-10-03 17:51   ` Roland Dreier [this message]
2006-10-03 18:02   ` Stephen Hemminger
2006-10-04  5:46     ` Kenji Kaneshige

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada3ba5s2x0.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muneda.takahiro@jp.fujitsu.com \
    --cc=shemminger@osdl.org \
    --cc=takeuchi_satoru@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox