From: Roland Dreier <rdreier@cisco.com>
To: "L. Alberto Giménez" <agimenez@sysvalve.es>
Cc: linux-kernel@vger.kernel.org, dgiagio@gmail.com,
dborca@yahoo.com, "Greg Kroah-Hartman" <gregkh@suse.de>,
"David S. Miller" <davem@davemloft.net>,
"Jonas Sjöquist" <jonas.sjoquist@ericsson.com>,
"Steve Glendinning" <steve.glendinning@smsc.com>,
"Torgny Johansson" <torgny.johansson@gmail.com>,
"David Brownell" <dbrownell@users.sourceforge.net>,
"Omar Laazimani" <omar.oberthur@gmail.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH Resubmission] drivers/net/usb: Add new driver ipheth
Date: Wed, 07 Apr 2010 15:37:15 -0700 [thread overview]
Message-ID: <ada6342zy78.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <1270678281-20750-1-git-send-email-agimenez@sysvalve.es> ("L. Alberto Giménez"'s message of "Thu, 8 Apr 2010 00:11:20 +0200")
These are a few of the cosmetic issues alluded to, and by no means merge
blockers, but:
> + schedule_delayed_work(&dev->carrier_work, IPHETH_CARRIER_CHECK_TIMEOUT);
Seems this might as well be round_jiffies_relative(IPHETH_CARRIER_CHECK_TIMEOUT)
to avoid extra wakeups.
> + netdev = alloc_etherdev(sizeof(struct ipheth_device));
This means that the interface will get an ethX name and look to
networkmanager et al like an ethernet device. Seems we would maybe want
to make this a "wwan" type device (cf drivers/net/usb/usbnet.c and how
it handles FLAG_WWAN)?
- R.
--
Roland Dreier <rolandd@cisco.com> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
next prev parent reply other threads:[~2010-04-07 22:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 21:34 [PATCH] Staging: Add new driver ipheth L. Alberto Giménez
2010-03-30 21:34 ` L. Alberto Giménez
2010-03-30 21:45 ` Greg KH
2010-03-30 21:58 ` "L. Alberto Giménez"
2010-03-30 22:11 ` Greg KH
2010-03-31 14:33 ` Pavel Machek
2010-03-31 14:44 ` Matthew Garrett
2010-03-31 19:47 ` "L. Alberto Giménez"
2010-03-30 23:01 ` [PATCH] drivers/net/usb: " L. Alberto Giménez
2010-03-30 23:25 ` Greg KH
2010-03-31 19:42 ` [PATCHv3] " L. Alberto Giménez
2010-03-31 20:33 ` Oliver Neukum
2010-03-31 21:38 ` "L. Alberto Giménez"
2010-04-02 18:23 ` "L. Alberto Giménez"
2010-04-04 7:24 ` Oliver Neukum
2010-04-05 18:51 ` "L. Alberto Giménez"
2010-03-31 23:18 ` Ben Hutchings
2010-03-31 23:25 ` Greg KH
2010-03-31 23:28 ` Ben Hutchings
2010-04-02 17:15 ` "L. Alberto Giménez"
2010-04-02 17:21 ` Ben Hutchings
2010-04-02 17:53 ` "L. Alberto Giménez"
2010-04-02 18:35 ` Ben Hutchings
2010-04-07 22:11 ` [PATCH Resubmission] " L. Alberto Giménez
2010-04-07 22:37 ` Roland Dreier [this message]
2010-04-08 6:35 ` Oliver Neukum
2010-04-13 8:15 ` David Miller
2010-04-13 19:03 ` "L. Alberto Giménez"
2010-04-13 21:29 ` David Miller
2010-04-15 19:46 ` [PATCH Resubmission v2] " L. Alberto Giménez
2010-04-16 6:44 ` David Miller
2010-04-18 18:35 ` [PATCH] " L. Alberto Giménez
2010-04-21 14:15 ` Diego Giagio
2010-04-22 5:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada6342zy78.fsf@roland-alpha.cisco.com \
--to=rdreier@cisco.com \
--cc=agimenez@sysvalve.es \
--cc=davem@davemloft.net \
--cc=dborca@yahoo.com \
--cc=dbrownell@users.sourceforge.net \
--cc=dgiagio@gmail.com \
--cc=gregkh@suse.de \
--cc=jonas.sjoquist@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=omar.oberthur@gmail.com \
--cc=steve.glendinning@smsc.com \
--cc=torgny.johansson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox