public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Dan Carpenter <error27@gmail.com>,
	linux-kernel@vger.kernel.org, jirislaby@gmail.com,
	Or Gerlitz <ogerlitz@voltaire.com>
Subject: Re: [PATCH 1/1] infiniband: ulp/iser, fix error retval in iser_create_ib_conn_res
Date: Tue, 16 Mar 2010 16:52:43 -0700	[thread overview]
Message-ID: <ada634v9644.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <1268750962-13547-1-git-send-email-jslaby@suse.cz> (Jiri Slaby's message of "Tue, 16 Mar 2010 15:49:22 +0100")

 >  	ib_conn->login_buf = kmalloc(ISER_RX_LOGIN_SIZE, GFP_KERNEL);
 >  	if (!ib_conn->login_buf) {
 > -		goto alloc_err;
 >  		ret = -ENOMEM;
 > +		goto alloc_err;
 >  	}

This looks like a valid fix but it's the same part of the code that Dan
found more extensive bugs in.  Or, can I assume you'll sort this out and
make sure a final patch is sorted out?

Thanks,
  Roland
-- 
Roland Dreier  <rolandd@cisco.com>
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html

  reply	other threads:[~2010-03-16 23:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-16 14:49 [PATCH 1/1] infiniband: ulp/iser, fix error retval in iser_create_ib_conn_res Jiri Slaby
2010-03-16 23:52 ` Roland Dreier [this message]
2010-03-17 15:11   ` Dan Carpenter
2010-03-31 21:06     ` Roland Dreier
2010-04-01 15:38       ` Dan Carpenter
2010-04-02 11:27       ` [patch v3] " Dan Carpenter
2010-05-05 18:09         ` Roland Dreier
2010-05-06 13:22           ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada634v9644.fsf@roland-alpha.cisco.com \
    --to=rdreier@cisco.com \
    --cc=error27@gmail.com \
    --cc=jirislaby@gmail.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ogerlitz@voltaire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox