public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: David Brownell <david-b@pacbell.net>, linux-kernel@vger.kernel.org
Subject: Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix
Date: Fri, 19 Oct 2007 22:44:46 -0700	[thread overview]
Message-ID: <ada6412bar5.fsf@cisco.com> (raw)
In-Reply-To: <20071020053642.GA4535@uranus.ravnborg.org> (Sam Ravnborg's message of "Sat, 20 Oct 2007 07:36:42 +0200")

 > Accoding to man bash "==" is used to test for equality and "=" is used for assignmnet.
 > I assume the above is a dash syntax error (dash is default on ubuntu IIRC).

My bash man page says the following under "CONDITIONAL EXPRESSIONS":

       string1 == string2
              True if the strings are equal.  = may be used in place
              of == for strict POSIX compliance.

This is bash 3.1 as packaged by Debian.

So I think "=" is the correct thing to use for compatibility with dash
or other non-bash shells, since as far as I know, there are no
situations where a comparison with "=" will fail but "==" will succed.
(ie "=" is strictly more compatible).

 - R.

  reply	other threads:[~2007-10-20  5:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-20  4:42 [patch 2.6.23-git] toplevel Makefile/depmod bugfix David Brownell
2007-10-20  5:36 ` Sam Ravnborg
2007-10-20  5:44   ` Roland Dreier [this message]
2007-10-20  5:52   ` David Brownell
2007-10-20 13:06     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada6412bar5.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox