[2.6.21-git2] sk_buff changes break Cisco VPN client

[2.6.21-git2] sk_buff changes break Cisco VPN client

[Alessandro Suardi]

skb_set_timestamp I can figure out, but the rest is a bit
 too hard for me... if anyone has already an idea of how
 to fix this, I'd be most grateful.

Cisco VPN client builds and works fine under 2.6.21 vanilla.

thanks in advance for any input ! ciao,

[root@sandman ~]# ciscobuild
make -C /share/src/linux-2.6.21-git2
SUBDIRS=/download/linux/net/vpnclient modules
make[1]: Entering directory `/share/src/linux-2.6.21-git2'
  CC [M]  /download/linux/net/vpnclient/linuxcniapi.o
/download/linux/net/vpnclient/linuxcniapi.c: In function 'CniInjectReceive':
/download/linux/net/vpnclient/linuxcniapi.c:299: warning: implicit
declaration of function 'skb_set_timestamp'
/download/linux/net/vpnclient/linuxcniapi.c:333: error: 'struct
sk_buff' has no member named 'nh'
/download/linux/net/vpnclient/linuxcniapi.c:334: error: 'struct
sk_buff' has no member named 'mac'
/download/linux/net/vpnclient/linuxcniapi.c: In function 'CniInjectSend':
/download/linux/net/vpnclient/linuxcniapi.c:456: error: 'struct
sk_buff' has no member named 'mac'
/download/linux/net/vpnclient/linuxcniapi.c:457: error: 'struct
sk_buff' has no member named 'nh'
/download/linux/net/vpnclient/linuxcniapi.c:460: error: 'struct
sk_buff' has no member named 'h'
/download/linux/net/vpnclient/linuxcniapi.c:460: error: 'struct
sk_buff' has no member named 'nh'
make[2]: *** [/download/linux/net/vpnclient/linuxcniapi.o] Error 1
make[1]: *** [_module_/download/linux/net/vpnclient] Error 2
make[1]: Leaving directory `/share/src/linux-2.6.21-git2'
make: *** [default] Error 2

--alessandro

 "Did you get married but forgot to get divorced ?"

     (Danny and Dusty, 'The Good Old Days')

Re: [2.6.21-git2] sk_buff changes break Cisco VPN client

[Phil Oester]

On Sat, Apr 28, 2007 at 10:38:45PM +0200, Alessandro Suardi wrote:
> skb_set_timestamp I can figure out, but the rest is a bit
> too hard for me... if anyone has already an idea of how
> to fix this, I'd be most grateful.

Did you ask Cisco?

Phil

Re: [2.6.21-git2] sk_buff changes break Cisco VPN client

[Roland Dreier]

This is really a problem for Cisco support, not the kernel people.
(And despite my email address I really have no idea who looks after
the VPN client).

However I can suggest vpnc (http://www.unix-ag.uni-kl.de/~massar/vpnc/)
as an alternative.  I'm not forced to use Cisco VPN access any more,
but when I tried it, vpnc was tons better than the Cisco product.

 - R.

Re: [2.6.21-git2] sk_buff changes break Cisco VPN client

[Alessandro Suardi]

On 4/28/07, Roland Dreier <rdreier@cisco.com> wrote:
> This is really a problem for Cisco support, not the kernel people.
> (And despite my email address I really have no idea who looks after
> the VPN client).

It's ok, I know it's "not a kernel issue". I just asked over here
 because I saw network code already converted to the new
 sk_buff code, and hoped someone could hint to a solution;
 I don't think it'd be extremely fruitful to ask Cisco since I'm
 already running a patched version of their latest official
 Linux release, which hasn't been updated for quite a while.

> However I can suggest vpnc (http://www.unix-ag.uni-kl.de/~massar/vpnc/)
> as an alternative.  I'm not forced to use Cisco VPN access any more,
> but when I tried it, vpnc was tons better than the Cisco product.

vpnc only started supporting hybrid-auth as of very, very
 recently; I used it before my company network turned to
 hybrid-auth-only several months ago. It's in my sights to go
 back to test vpnc-0.4.0 with the hybrid-auth support patch
 in the near future. But in the meantime I'll be stuck with
 the Cisco VPN client.

After clarifying all this, I'll respectfully ask again whether
 anyone has an idea about how to go fixing the five or so
 lines of the skb stuff impacted by the kernel changes -
 and will of course take no offense if nobody can help, while
 happily ignoring those who can only contribute what I do
 already know, that is - this isn't a kernel issue.

Thanks again in advance, ciao,

--alessandro

 "Did you get married but forgot to get divorced ?"

     (Danny and Dusty, 'The Good Old Days')

Re: [2.6.21-git2] sk_buff changes break Cisco VPN client

[David Miller]

From: Roland Dreier <rdreier@cisco.com>
Date: Sat, 28 Apr 2007 14:05:27 -0700

> However I can suggest vpnc (http://www.unix-ag.uni-kl.de/~massar/vpnc/)
> as an alternative.  I'm not forced to use Cisco VPN access any more,
> but when I tried it, vpnc was tons better than the Cisco product.

Also, and I know this might be a COMPLETE SHOCK to some people, but we
do have a full in-kernel IPSEC stack and using it with openswan to
connect to VPNs works perfectly fine.

I use it every day.

It's quite amusing that people use a userland IPSEC implementation
via VPNC, in spite of this.

Re: [2.6.21-git2] sk_buff changes break Cisco VPN client

[Alessandro Suardi]

On 4/29/07, David Miller <davem@davemloft.net> wrote:
> From: Roland Dreier <rdreier@cisco.com>
> Date: Sat, 28 Apr 2007 14:05:27 -0700
>
> > However I can suggest vpnc (http://www.unix-ag.uni-kl.de/~massar/vpnc/)
> > as an alternative.  I'm not forced to use Cisco VPN access any more,
> > but when I tried it, vpnc was tons better than the Cisco product.
>
> Also, and I know this might be a COMPLETE SHOCK to some people, but we
> do have a full in-kernel IPSEC stack and using it with openswan to
> connect to VPNs works perfectly fine.
>
> I use it every day.
>
> It's quite amusing that people use a userland IPSEC implementation
> via VPNC, in spite of this.
>

Have a look here

https://lists.dulug.duke.edu/pipermail/dulug/2007-March/010792.html

 where someone seems to be in my same boat. No, openswan/IPSEC
 does not work in all configurations with Cisco VPN concentrators -
 and by Murphy's law, I'm in the non-working configuration.

Hope this clarifies the reason I asked. And if anyone out there
 is in doubt about it, I absolutely hate having to rebuild an out
 of kernel module every time I build a kernel, crossing fingers
 it doesn't break (again). I would use *anything* else.

--alessandro

 "Did you get married but forgot to get divorced ?"

     (Danny and Dusty, 'The Good Old Days')

Re: [2.6.21-git2] sk_buff changes break Cisco VPN client

[Alan Cox]

On Sat, 28 Apr 2007 22:38:45 +0200
"Alessandro Suardi" <alessandro.suardi@gmail.com> wrote:

> skb_set_timestamp I can figure out, but the rest is a bit
>  too hard for me... if anyone has already an idea of how
>  to fix this, I'd be most grateful.
> 
> Cisco VPN client builds and works fine under 2.6.21 vanilla.

Perhaps if cisco included full source they could get their code merged,
in the meantime why not throw it away and use vpnclient like everyone
else ?