From: Roland Dreier <rdreier@cisco.com>
To: akpm@linux-foundation.org, gregkh@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: commit 45cd8d8e -- why?
Date: Fri, 27 Apr 2007 19:50:19 -0700 [thread overview]
Message-ID: <ada647hnrf8.fsf@cisco.com> (raw)
The changelog says:
fs/sysfs/bin.c: In function 'read':
fs/sysfs/bin.c:77: warning: format '%zd' expects type 'signed size_t', but argument 4 has type 'int'
but the signature of the function read() is
read(struct file * file, char __user * userbuf, size_t count, loff_t * off)
and git blame seems to show it was always thus -- ie count was always size_t.
And now on x86-64 and ia64 with gcc 4.1 at least, I get:
fs/sysfs/bin.c: In function 'read':
fs/sysfs/bin.c:62: warning: format '%d' expects type 'int', but argument 4 has type 'size_t'
Andrew, what compiler were you using to get that warning? Should we
revert commit 45cd8d8e?
- R.
next reply other threads:[~2007-04-28 2:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-28 2:50 Roland Dreier [this message]
2007-04-28 4:49 ` commit 45cd8d8e -- why? Andrew Morton
2007-04-28 4:54 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada647hnrf8.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox