Re: [PATCH 2.6.17-rc4 6/6] Remove some of the kmemleak false positives

Jesper Juhl
2006-05-13T19:21:40Z

On 13/05/06, Catalin Marinas <catalin.marinas@gmail.com> wrote:
> From: Catalin Marinas <catalin.marinas@arm.com>
>
> There are allocations for which the main pointer cannot be found but they
> are not memory leaks. This patch fixes some of them.
>
[snip]
> +#ifdef CONFIG_DEBUG_MEMLEAK
> + /* avoid a false alarm. That's not a memory leak */
> + memleak_free(out);
> +#endif

Hmm, so eventually we are going to end up with a bunch of ugly #ifdef
CONFIG_DEBUG_MEMLEAK's all over the place?

Wouldn't it be better to just make memleak_free() an empty stub in the
!CONFIG_DEBUG_MEMLEAK case?

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html