Re: [PATCH 2.6.17-rc4 3/6] Add the memory allocation/freeing hooks for kmemleak

Pekka Enberg
2006-05-14T14:49:32Z

On 5/13/06, Catalin Marinas <catalin.marinas@gmail.com> wrote:
> From: Catalin Marinas <catalin.marinas@arm.com>
>
> This patch adds the callbacks to memleak_(alloc|free) functions from
> kmalloc/kree, kmem_cache_(alloc|free), vmalloc/vfree etc.
>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

Way too many #ifdefs. Instead, please make memleak_alloc() and
memleak_free() empty static inline functions for the
non-CONFIG_DEBUG_MEMLEAK case.

Pekka