Re: [PATCH 2.6.17-rc4 6/6] Remove some of the kmemleak false positives

Catalin Marinas
2006-05-14T07:31:58Z

Jesper Juhl wrote:
> On 13/05/06, Catalin Marinas <catalin.marinas@gmail.com> wrote:
>> +#ifdef CONFIG_DEBUG_MEMLEAK
>> + /* avoid a false alarm. That's not a memory leak */
>> + memleak_free(out);
>> +#endif
>
>
> Hmm, so eventually we are going to end up with a bunch of ussgly #ifdef
> CONFIG_DEBUG_MEMLEAK's all over the place?
>
> Wouldn't it be better to just make memleak_free() an empty stub in the
> !CONFIG_DEBUG_MEMLEAK case?

Yes, I'll make empty stubs (Paul suggested this as well).

Catalin