Re: [PATCH 2.6.17-rc4 1/6] Base support for kmemleak

Ingo Oeser
2006-05-14T17:35:11Z

Hi Catalin,

On Sunday, 14. May 2006 09:24, Catalin Marinas wrote:
> >> +#if 0
> >> + /* make some orphan pointers for testing */
> >> + kmalloc(32, GFP_KERNEL);
> >> + kmalloc(32, GFP_KERNEL);
> >> + kmem_cache_alloc(pointer_cache, GFP_ATOMIC);
> >> + kmem_cache_alloc(pointer_cache, GFP_ATOMIC);
> >> + vmalloc(64);
> >> + vmalloc(64);
> >> +#endif
> >
> > Stuff for testing is nice, but do we have to add it to the kernel? - I
> > assume you are done testing :-)
> > We have waay too much code already in the kernel inside #if 0
>
> The best would be to test it using a loadable module but I did most of
> the work on an embedded ARM platform where it was much easier to add
> some code directly. The code will be cleaned up in subsequent versions.

Fair enough. Just put it in a seperate file,
add a Kconfig "TEST_MEMLEAK_DETECTOR" tristate option,
depending on "DEBUG_MEMLEAK" and adjust the Makefile accordingly.

That way we can activate it from time to time by loading that module
and you can test it by compiling a new kernel.

RCU and CRYPTO have similiar features.

Regards

Ingo Oeser