public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Steve Wise <swise@opengridcomputing.com>
Cc: stable@kernel.org, linux-rdma@vger.kernel.org,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/cxgb4: Add default_llseek to debugfs files.
Date: Wed, 29 Sep 2010 11:52:10 -0700	[thread overview]
Message-ID: <ada8w2k2xid.fsf@cisco.com> (raw)
In-Reply-To: <20100929141112.26944.21931.stgit@build.ogc.int> (Steve Wise's message of "Wed, 29 Sep 2010 09:11:12 -0500")

 > --- a/drivers/infiniband/hw/cxgb4/device.c
 > +++ b/drivers/infiniband/hw/cxgb4/device.c
 > @@ -182,6 +182,7 @@ static const struct file_operations qp_debugfs_fops = {
 >  	.open    = qp_open,
 >  	.release = qp_release,
 >  	.read    = debugfs_read,
 > +	.llseek  = default_llseek,
 >  };
 >  
 >  static int dump_stag(int id, void *p, void *data)
 > @@ -255,6 +256,7 @@ static const struct file_operations stag_debugfs_fops = {
 >  	.open    = stag_open,
 >  	.release = stag_release,
 >  	.read    = debugfs_read,
 > +	.llseek  = default_llseek,
 >  };
 >  
 >  static int setup_debugfs(struct c4iw_dev *devp)
 > 
 > 

Steve, can you also do a quick test to make sure this works OK with
generic_file_llseek instead of default_llseek?

Thanks.

      parent reply	other threads:[~2010-09-29 18:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-29 14:11 [PATCH] RDMA/cxgb4: Add default_llseek to debugfs files Steve Wise
2010-09-29 17:19 ` Roland Dreier
2010-09-29 17:27   ` Steve Wise
2010-09-29 17:41     ` Roland Dreier
2010-09-29 17:49       ` Steve Wise
2010-09-29 17:50         ` Roland Dreier
2010-09-29 19:17   ` Arnd Bergmann
2010-09-29 19:21     ` Roland Dreier
2010-09-29 19:29       ` Arnd Bergmann
2010-09-29 19:40         ` Roland Dreier
2010-09-29 18:52 ` Roland Dreier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada8w2k2xid.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox