From: Roland Dreier <rdreier@cisco.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Mike Travis <travis@sgi.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] x86, mce: disable MCE if cpu has no MCE banks
Date: Wed, 28 Oct 2009 10:12:47 -0700 [thread overview]
Message-ID: <ada8wevtpbk.fsf@cisco.com> (raw)
In-Reply-To: <4AE7E931.6040703@linux.intel.com> (Andi Kleen's message of "Wed, 28 Oct 2009 07:48:17 +0100")
> Perhaps they could be also compressed a bit like SRAT.
Seems like a good idea... but I wonder what the best way to represent
things is. For example I have a 2-socket Nehalem system that shows:
2 times: MCA banks CMCI:2 CMCI:3 CMCI:5 CMCI:6 SHD:8
6 times: MCA banks CMCI:2 CMCI:3 CMCI:5 SHD:6 SHD:8
8 times: MCA banks SHD:2 SHD:3 SHD:5 SHD:6 SHD:8
presumably the first line is once per package, the next line is for the
first sibling in all the other cores in a package, and the last line is
for the SMT siblings of all the cores.
But would we want to accumulate all the different combinations of banks
along with a CPU mask and then print something like:
CPUs 0 4: MCA banks CMCI:2 CMCI:3 CMCI:5 CMCI:6 SHD:8
CPUs 1 2 3 5 6 7: MCA banks CMCI:2 CMCI:3 CMCI:5 SHD:6 SHD:8
CPUs 8 9 10 11 12 13 14 15: MCA banks SHD:2 SHD:3 SHD:5 SHD:6 SHD:8
of course output like that is going to lead to super-long lines on a
64-thread system.
Also I'm not sure of a clean way to implement this; unlike the SRAT
stuff, we need to deal with CPU hotplug so all this at best could be
__cpuinitdata, ie we can't discard it in most configs.
However the "MCA banks" output definitely is annoying on a 64-thread
system -- the amount of output is far greater than the utility of said
output. So ideas on the best way to reduce this would be appreciated.
Thanks,
Roland
next prev parent reply other threads:[~2009-10-28 17:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 21:21 [PATCH] x86: Don't print number of MCE banks for every CPU Roland Dreier
2009-10-16 7:20 ` Ingo Molnar
2009-10-16 7:22 ` [tip:x86/urgent] " tip-bot for Roland Dreier
2009-10-27 19:42 ` [PATCH] " Mike Travis
2009-10-27 20:53 ` Mike Travis
2009-10-28 4:07 ` [PATCH] x86, mce: disable MCE if cpu has no MCE banks Hidetoshi Seto
2009-10-28 5:24 ` Andi Kleen
2009-10-28 6:26 ` Hidetoshi Seto
2009-10-28 6:48 ` Andi Kleen
2009-10-28 8:18 ` Hidetoshi Seto
2009-10-28 17:09 ` Mike Travis
2009-10-28 17:12 ` Roland Dreier [this message]
2009-10-28 17:37 ` Mike Travis
2009-10-28 18:03 ` Roland Dreier
2009-10-28 12:03 ` Valdis.Kletnieks
2009-10-28 13:44 ` Andi Kleen
2009-10-28 4:26 ` [PATCH] x86: Don't print number of MCE banks for every CPU Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada8wevtpbk.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox