public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: "Satyam Sharma" <satyam.sharma@gmail.com>
Cc: "Paul Mundt" <lethal@linux-sh.org>,
	"Roland Dreier" <rolandd@cisco.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: trivial MLX4_DEBUG dependency fix.
Date: Thu, 10 May 2007 11:20:14 -0700	[thread overview]
Message-ID: <ada8xbw1qxt.fsf@cisco.com> (raw)
In-Reply-To: <a781481a0705100511l1bfdc7f3tc2669eb916f76594@mail.gmail.com> (Satyam Sharma's message of "Thu, 10 May 2007 17:41:21 +0530")

 > IMHO default configs must be aimed at production usage scenarios, so
 > are better off without debugging enabled by default. Except if the
 > driver is really new / EXPERIMENTAL where the goal is to get it tested
 > out by all users asap (and no production systems would be using it
 > anyway).

I agree, but I would hope that MLX4_DEBUG *is* enabled in production.
It doesn't print anything or introduce any measurable overhead except
for slightly larger code size unless the debug level is explicitly
increased, so the only reason to turn it off is if a few bytes of code
makes a big difference to you (hence making it selectable only if
EMBEDDED is selected).

  reply	other threads:[~2007-05-10 18:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-10  3:50 [PATCH] net: trivial MLX4_DEBUG dependency fix Paul Mundt
2007-05-10 11:42 ` Roland Dreier
2007-05-10 12:11   ` Satyam Sharma
2007-05-10 18:20     ` Roland Dreier [this message]
2007-05-10 12:49   ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada8xbw1qxt.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rolandd@cisco.com \
    --cc=satyam.sharma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox