public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Hoang-Nam Nguyen <hnguyen@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	general@lists.openfabrics.org, hch@infradead.org,
	raisch@de.ibm.com, heiko.carstens@de.ibm.com
Subject: Re: [PATCH 2.6.21-rc2] ehca: fix mismatched sync between completion handler and destroy cq
Date: Thu, 01 Mar 2007 13:04:05 -0800	[thread overview]
Message-ID: <ada8xegr7zu.fsf@cisco.com> (raw)
In-Reply-To: <200702281801.02747.hnguyen@linux.vnet.ibm.com> (Hoang-Nam Nguyen's message of "Wed, 28 Feb 2007 18:01:02 +0100")

Looks OK to me, queued for 2.6.21, except:

 > +#include <linux/completion.h>

This can just be <linux/wait.h>, because you're only using
wait_queue_head_t and not struct completion, right?

I fixed this up before merging.

  reply	other threads:[~2007-03-01 21:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-28 17:01 [PATCH 2.6.21-rc2] ehca: fix mismatched sync between completion handler and destroy cq Hoang-Nam Nguyen
2007-03-01 21:04 ` Roland Dreier [this message]
2007-03-02  8:37   ` Hoang-Nam Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada8xegr7zu.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=general@lists.openfabrics.org \
    --cc=hch@infradead.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hnguyen@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=raisch@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox