From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DD243D16E6 for ; Wed, 8 Apr 2026 16:43:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775666619; cv=none; b=Cwrcaj4LkjaiVhxpmkD7oXtDkKVuiaCjzPws9Ba3AqYW3sjI0eieCnb/YOz8sN8wQAVLiyjw2poT5hm2PLwihOKDrTaCGtNu6a2oRqQl4mfMKt4YjZVfaLRPb0QQxNiruaFFIG5Guc2/fJf73z56TKuTImcr+YlCa4jHQwYNG/s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775666619; c=relaxed/simple; bh=ZsmZkNWjvfLQnLUnLwC+S9ery1VMukelPAc+HmzPAQo=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ovUnSF/51XcEJIDR3Q0o8ckCviEAAA16JuybwtbQ/3m/G6DmP6QoXhxpKJulZOA4GkqGSlzIdGGgD4Q4iVs2Hx58pteyuT0n+4i0y/clvbt1neriUsl84qJN4YNXa85ahvyJYKy3BcBstE/wgTgCFrZ5yn8p1eCwcSc5m8J3vEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cCRg0nq5; arc=none smtp.client-ip=209.85.167.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cCRg0nq5" Received: by mail-oi1-f195.google.com with SMTP id 5614622812f47-46fb6d65c89so24280b6e.1 for ; Wed, 08 Apr 2026 09:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775666617; x=1776271417; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=ExRf4HLhLOoGUxPF6JxR6INr+6Sdip5p0HRwO8b3SNs=; b=cCRg0nq5ubGqUMmJyTfnX7B+hbsMbebQIpbwuIKBO3g5eDjXOQdPNPTBRyu1gvVtKd owpnkNoX7lSkxObnxEp2EzFFNr1WbhSkOYeJcW3GqpC/dXJv1msL8YGNwjy+rlo3CjVF 8EmpMni/Vgaidd6Kli9RqmcSsuc9c8gWRi9VSMgptpWW9mueEW3MTWLS+fLlqe4ZZN47 aF0rVa6E74ZkNWEXhYEWvfV6379/26rdUak1BEfDNuB75BP8Ds6aDgDcNnbXnt4WsCbL 5bEmDLHcQZp+J4QAxw/st/eoSdDHZ1Uev1xV8aciIatK3AVzyoSEZm5NaTQ2cDRXwot7 3fog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775666617; x=1776271417; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ExRf4HLhLOoGUxPF6JxR6INr+6Sdip5p0HRwO8b3SNs=; b=OXO8qfFz9YgDD5CpiekDZspJ5GiI8j9ZA37NU1ljGlLWPHqrHAJvIwKamQRuIqtLwD EwZSSHS6/f3mpeXANqg1GhthXFG/GcX3HFzpzJ9fVHndRCxpi93tottiXM58j1FU8jel mDNT1LroQY3f0maAurLr8HitjqzCMktV/FwbYHS10aK5AiNaiO+ql/u7svoPwsJaqSNK ax2mvf5HJQYPHWSyCEmRGtrqmBP5yJkJFMmXLVxRpi2TxLplnXRarUmbrRFA8dwcyq0O qh9TCUC3GtZ0nyX6A3oWXbGUFb0pDIVrZ4E4P2XleEPCedV4jzLguDIFs490oVgWsGwi ndDA== X-Forwarded-Encrypted: i=1; AJvYcCW0mv+Keib+botV24b77En1FcEoFtgvxvLBpeDxaXATkjXJTbuAr8OKwGewIUX7johzkrav/9SIqfKHp7g=@vger.kernel.org X-Gm-Message-State: AOJu0YzLG7xf2D8UIjy6pAlyZPpQxlaq1vRltQ5sJOaYz7151BovGleO 2GlAR1jSr3l3F6+cGnnvk7Rlp+2N7Z6lbxFKFblGlgXxrU2W7ZCRQ7kN X-Gm-Gg: AeBDievj4Pjc3F/EcLCgid3YnDGlpiK2iXm1oRMdMm+aBXlHvvnrxAEw86oIJ43rBDE jT6nF67LZv7qadW7InZQC44fnummpsbbgBQG5J95uAjUY/L6nhgD7wcNRpoi0y+B9Z6YLNt/V+T 66NQcSNW2Y3vwmBZR1CZ/3BJXS8Mz2Tk8a6IJnBguCo1ehmZ5Ad9elBMHypdM/0EnHdrQvM3UQT M7lWRsPbhcfCbVn7k5htFzOWRAW7Fdm51viBohuFczATXyHe1yvDI+/E69YhFwjUPKnsTYXHx1l q4PPrbi63fHTMZsR5+CPgWHbseLORX/RBU8g50oxQtFKcenuUXJUftuB/cfB2B00eX+pwFaMz6n ufHuryjVvR9A4DkXOv7+FqcpDQhvD7Pt4Ksh4UW7l3m+C25WBhqrtZNT59O4yairwBgPZo0LlsB Te4cEdMhtMe5apUNgXXmHG7+eAfNV2 X-Received: by 2002:a05:6808:c183:b0:45c:925b:5848 with SMTP id 5614622812f47-4772407f243mr200072b6e.45.1775666616928; Wed, 08 Apr 2026 09:43:36 -0700 (PDT) Received: from localhost ([2a03:2880:12ff:73::]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-42356d581c1sm8153584fac.4.2026.04.08.09.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 09:43:36 -0700 (PDT) From: Stanislav Fomichev X-Google-Original-From: Stanislav Fomichev Date: Wed, 8 Apr 2026 09:43:35 -0700 To: Hangbin Liu Cc: Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 5/5] ethtool: strset: check nla_len overflow Message-ID: References: <20260408-b4-ynl_ethtool-v2-0-7623a5e8f70b@gmail.com> <20260408-b4-ynl_ethtool-v2-5-7623a5e8f70b@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260408-b4-ynl_ethtool-v2-5-7623a5e8f70b@gmail.com> On 04/08, Hangbin Liu wrote: > The netlink attribute length field nla_len is a __u16, which can only > represent values up to 65535 bytes. NICs with a large number of > statistics strings (e.g. mlx5_core with thousands of ETH_SS_STATS > entries) can produce a ETHTOOL_A_STRINGSET_STRINGS nest that exceeds > this limit. > > When nla_nest_end() writes the actual nest size back to nla_len, the > value is silently truncated. This results in a corrupted netlink message > being sent to userspace: the parser reads a wrong (truncated) attribute > length and misaligns all subsequent attribute boundaries, causing decode > errors. > > Fix this by using the new helper nla_nest_end_safe and error out if > the size exceeds U16_MAX. Not sure that's the user supposed to do? Does it mean there is no way to retrieve ETHTOOL_A_STRINGSET_STRINGS for those devices with too many strings?