Re: SCSI breakage on non-cache coherent architectures

James Bottomley
2007-11-19T15:09:49Z

On Mon, 2007-11-19 at 05:32 -0700, Matthew Wilcox wrote:
> On Mon, Nov 19, 2007 at 04:35:23PM +1100, Benjamin Herrenschmidt wrote:
> > The other one I'm hitting now is that the SCSI layer nowadays embeds the
>
> 'nowadays'? It has always been so.
>
> > sense_buffer inside the scsi_cmnd structure without any kind of
> > alignment whatsoever. I've been hitting irregulary is a crash on SCSI command
> > completion that seems to be related to corruption of the "request"
> > pointer in struct scsi_cmnd and I think it might be the cause.
> > I'm now trying to setup a proper repro-case.
>
> What other drivers do is DMA to their own allocation and then memcpy to
> the sense buffer.
>
> There is a movement to allocate the sense data as its own sg list, but
> I don't think that patch has even been posted yet.

I'd like to be rid of it inside the command for various reasons: every
command has one of these, and they're expensive in the allocation (at 96
bytes). There's no reason we have to allocate and free that amount of
space with every command. In theory, the number of these is bounded at
the queue depth, in practice, there's usually only one, and this DMA
alignment issue does requires most drivers to double copy.

James