From: Roland Dreier <rdreier@cisco.com>
To: "Bryan O'Sullivan" <bos@pathscale.com>
Cc: "Michael S. Tsirkin" <mst@mellanox.co.il>,
linux-kernel@vger.kernel.org, greg@kroah.com,
openib-general@openib.org
Subject: Re: [PATCH 9 of 18] ipath - char devices for diagnostics and lightweight subnet management
Date: Thu, 23 Mar 2006 11:18:53 -0800 [thread overview]
Message-ID: <adaacbhvujm.fsf@cisco.com> (raw)
In-Reply-To: <1143103701.6411.21.camel@camp4.serpentine.com> (Bryan O'Sullivan's message of "Thu, 23 Mar 2006 00:48:21 -0800")
Bryan> We have customers who use our driver who do not want a full
Bryan> IB stack present, for example in embedded environments.
I think it's fine that your low-level driver can work without ib_core,
ib_mad and the rest loaded. But I still (after all this discussion)
don't understand why you need to have two SMA implementations to
handle this along with the code to switch between the two modes like:
> + list_for_each_entry(dd, &ipath_dev_list, ipath_list) {
> + if (!(dd->ipath_flags & IPATH_INITTED))
> + continue;
> + *dd->ipath_statusp &= ~IPATH_STATUS_SMA;
> + if (ipath_verbs_registered)
> + *dd->ipath_statusp |= IPATH_STATUS_OIB_SMA;
> + }
You also have all the functions like recv_subn_get_nodeinfo() etc. for
handling SM queries. Presumably all this is duplicated in the
userspace SMA. Why can't you get down to one NodeInfo query handler?
- R.
next prev parent reply other threads:[~2006-03-23 19:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-23 0:04 [PATCH 0 of 18] [RFC] ipath - almost-final round of patches for submission Bryan O'Sullivan
2006-03-23 0:04 ` [PATCH 1 of 18] ipath - core driver header files Bryan O'Sullivan
2006-03-23 0:04 ` [PATCH 2 of 18] ipath - core device driver Bryan O'Sullivan
2006-03-23 0:04 ` [PATCH 3 of 18] ipath - copy and send routines for sending an skb Bryan O'Sullivan
2006-03-23 0:04 ` [PATCH 4 of 18] ipath - support for HyperTransport devices Bryan O'Sullivan
2006-03-23 0:04 ` [PATCH 5 of 18] ipath - support for PCI Express devices Bryan O'Sullivan
2006-03-23 0:04 ` [PATCH 6 of 18] ipath - chip initialisation code Bryan O'Sullivan
2006-03-23 0:05 ` [PATCH 7 of 18] ipath - misc driver support code Bryan O'Sullivan
2006-03-23 0:05 ` [PATCH 8 of 18] ipath - sysfs and ipathfs support for core driver Bryan O'Sullivan
2006-03-23 5:49 ` Greg KH
2006-03-23 8:44 ` Bryan O'Sullivan
2006-03-23 20:06 ` Robert Walsh
2006-03-23 23:25 ` Greg KH
2006-03-23 6:30 ` Michael S. Tsirkin
2006-03-23 8:46 ` Bryan O'Sullivan
2006-03-23 9:40 ` Michael S. Tsirkin
2006-03-23 0:05 ` [PATCH 9 of 18] ipath - char devices for diagnostics and lightweight subnet management Bryan O'Sullivan
2006-03-23 6:41 ` Michael S. Tsirkin
2006-03-23 8:48 ` Bryan O'Sullivan
2006-03-23 9:37 ` Michael S. Tsirkin
2006-03-23 9:51 ` Bryan O'Sullivan
2006-03-23 10:13 ` Michael S. Tsirkin
2006-03-23 10:19 ` Bryan O'Sullivan
2006-03-23 19:18 ` Roland Dreier [this message]
2006-03-23 23:58 ` Bryan O'Sullivan
2006-03-24 1:27 ` Roland Dreier
2006-03-24 2:59 ` [openib-general] " Robert Walsh
2006-03-23 0:05 ` [PATCH 10 of 18] ipath - support for userspace apps using core driver Bryan O'Sullivan
2006-03-23 3:06 ` Andrew Morton
2006-03-23 8:37 ` Bryan O'Sullivan
2006-03-23 0:05 ` [PATCH 11 of 18] ipath - layering interfaces used by higher-level driver code Bryan O'Sullivan
2006-03-23 0:05 ` [PATCH 12 of 18] ipath - infiniband header files Bryan O'Sullivan
2006-03-23 0:05 ` [PATCH 13 of 18] ipath - infiniband UC and UD protocol support Bryan O'Sullivan
2006-03-23 0:05 ` [PATCH 14 of 18] ipath - infiniband RC " Bryan O'Sullivan
2006-03-23 0:05 ` [PATCH 15 of 18] ipath - misc infiniband code, part 1 Bryan O'Sullivan
2006-03-23 0:05 ` [PATCH 16 of 18] ipath - misc infiniband code, part 2 Bryan O'Sullivan
2006-03-23 0:05 ` [PATCH 17 of 18] ipath - infiniband verbs support Bryan O'Sullivan
2006-03-23 0:05 ` [PATCH 18 of 18] ipath - kbuild infrastructure Bryan O'Sullivan
-- strict thread matches above, loose matches on Subject: below --
2006-03-24 4:41 [PATCH 0 of 18] ipath driver - for inclusion in 2.6.17 Bryan O'Sullivan
2006-03-24 4:41 ` [PATCH 9 of 18] ipath - char devices for diagnostics and lightweight subnet management Bryan O'Sullivan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaacbhvujm.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=bos@pathscale.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@mellanox.co.il \
--cc=openib-general@openib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox