From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH v3] f2fs: do not support mmap write for large folio
Date: Wed, 8 Apr 2026 18:13:06 +0000 [thread overview]
Message-ID: <adaasm42rLxRY2GN@google.com> (raw)
In-Reply-To: <20260406154940.2407853-1-jaegeuk@kernel.org>
Let's check mmap writes onto the large folio, since we don't support writing
large folios.
Reviewed-by: Daeho Jeong <daehojeong@google.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
- log v2:
: add comments
fs/f2fs/file.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 2c4880f24b54..c0220cd7b332 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -82,7 +82,12 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
int err = 0;
vm_fault_t ret;
- if (unlikely(IS_IMMUTABLE(inode)))
+ /*
+ * We only support large folio on the read case.
+ * Don't make any dirty pages.
+ */
+ if (unlikely(IS_IMMUTABLE(inode)) ||
+ mapping_large_folio_support(inode->i_mapping))
return VM_FAULT_SIGBUS;
if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) {
--
2.53.0.1213.gd9a14994de-goog
next prev parent reply other threads:[~2026-04-08 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 15:49 [PATCH] f2fs: do not support mmap write for large folio Jaegeuk Kim
2026-04-06 15:57 ` [f2fs-dev] " Daeho Jeong
2026-04-06 16:57 ` Jaegeuk Kim
2026-04-07 5:17 ` Christoph Hellwig
2026-04-07 22:58 ` Jaegeuk Kim
2026-04-08 5:03 ` Christoph Hellwig
2026-04-08 14:07 ` David Hildenbrand (Arm)
2026-04-08 18:08 ` Jaegeuk Kim
2026-04-08 18:13 ` Jaegeuk Kim [this message]
2026-04-09 5:40 ` [PATCH v3] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaasm42rLxRY2GN@google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox