From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B66C71E5724 for ; Wed, 8 Apr 2026 18:13:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775671988; cv=none; b=KN9tvK0hpFDxp3fATKCtQ3i0xxJBcqkEioifZgd4Vxn4hK8j0b0Ov7UZauTqFzkWmScP4A+37MYOhGkvKgaxyjFQ0a5GPHN6R6jNlmjTBIztuKVwDLxd/VmNZe/0LrAJio03eu9aHtT+OR8VLLp69UGcp2OCuBvHe4uQ25pg1nY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775671988; c=relaxed/simple; bh=dqzQLKq0cVpjLfRqGnLvvW4jDvNvFUXj35X1JhYiyCY=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k9lOmuHOOObMJkFZGLU0KpikUvmQ4g/7XZLN2WsVwKdV9Tu4hRUYSfXehpi+WtckYVTdV9BKdgY4v9dSGhEltctAGJKY5wM0JCIEDuMenWez2DF8Mv/zAI26AHlAh33eX5DTjEAiOmLygGNhEcq5LbUOzh5ATTyrhHvWGzLfIEI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T3VD4OlT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T3VD4OlT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 314A8C19421; Wed, 8 Apr 2026 18:13:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775671988; bh=dqzQLKq0cVpjLfRqGnLvvW4jDvNvFUXj35X1JhYiyCY=; h=Date:From:To:Subject:References:In-Reply-To:From; b=T3VD4OlTVJQEe70UJ+HwyjJFbFPq5h46JHgQM6YJbgjBjSjFMGrxUE29Cp6lNVTSU 4B2vKBDQ3h3FxwrwXzMz2hTL4WCJ8V38vX5ALjlPjceiVwMNeXHsbPINdS8GKSIDGJ f/KCn85XS4Bx+k/Cc4Sfh1l/zkxFL89ukYsLH7dBOKZpusQKi4PCbw2BIPeMdGLpwM MTepnklb1tATkZgAUZisCO5U6mR95aTg2+aEpM6ige+vH1ZKmYH24aw72HiyKyqimp SS0DBCYVp8aFlZbyJEXPivbxTPNvEcmtGoDOpsjxwWr7s844LuQIla0g4bcWg/Ajh3 qnurIJM3ugO3g== Date: Wed, 8 Apr 2026 18:13:06 +0000 From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v3] f2fs: do not support mmap write for large folio Message-ID: References: <20260406154940.2407853-1-jaegeuk@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260406154940.2407853-1-jaegeuk@kernel.org> Let's check mmap writes onto the large folio, since we don't support writing large folios. Reviewed-by: Daeho Jeong Signed-off-by: Jaegeuk Kim --- - log v2: : add comments fs/f2fs/file.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 2c4880f24b54..c0220cd7b332 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -82,7 +82,12 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf) int err = 0; vm_fault_t ret; - if (unlikely(IS_IMMUTABLE(inode))) + /* + * We only support large folio on the read case. + * Don't make any dirty pages. + */ + if (unlikely(IS_IMMUTABLE(inode)) || + mapping_large_folio_support(inode->i_mapping)) return VM_FAULT_SIGBUS; if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) { -- 2.53.0.1213.gd9a14994de-goog