Re: [GIT PULL] ocfs2 changes for 2.6.32

Linus Torvalds
2009-09-17T20:16:30Z

On Thu, 17 Sep 2009, Arjan van de Ven wrote:
>
> or make it one level simpler?
> Have a "wait for all started copies" call only.... saves a ton of book
> keeping, and is likely what people will use it for in the end anyway.

No. That wouldn't work. For a few reasons:

- the case I didn't show was the "graphical file manager client" thing
that wants to show the copy as it progresses. It needs to know how much
is left, and for which file.

- if errors happen, you need to indicate which file had an error. Again,
my example code didn't show that, since it was written as an example
and obviously just while writing email anyway. But it's a major
requirement for any sane and reliable filesystem model!

- even in my example, I wanted to show how you don't want to wait for
_all_ of them in the middle, you just want to wait for some of them. If
you wait for all of them - just to make room for more - you're going to
have hickups in your IO patterns and you cannot saturate your server or
disks well.

So I really think there needs to be a cookie per outstanding file copy (of
course, the kernel is likely to not allow a single user more than 'n'
outstanding copies anyway, but that's a separate issue).

Linus