* [PATCH] ivtv: don't recompile needlessly
@ 2007-07-17 11:47 Alexey Dobriyan
2007-07-17 12:03 ` Hans Verkuil
2007-07-17 15:26 ` Roland Dreier
0 siblings, 2 replies; 3+ messages in thread
From: Alexey Dobriyan @ 2007-07-17 11:47 UTC (permalink / raw)
To: akpm, v4l-dvb-maintainer; +Cc: linux-kernel, hverkuil
Driver prints 3l33t banner including kernel version.
Could we _please_ never do this in future.
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---
drivers/media/video/ivtv/ivtv-driver.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/media/video/ivtv/ivtv-driver.c
+++ b/drivers/media/video/ivtv/ivtv-driver.c
@@ -56,7 +56,6 @@
#include "ivtv-gpio.h"
#include "ivtv-yuv.h"
-#include <linux/vermagic.h>
#include <media/tveeprom.h>
#include <media/v4l2-chip-ident.h>
@@ -1315,7 +1314,7 @@ static struct pci_driver ivtv_pci_driver = {
static int module_start(void)
{
printk(KERN_INFO "ivtv: ==================== START INIT IVTV ====================\n");
- printk(KERN_INFO "ivtv: version %s (" VERMAGIC_STRING ") loading\n", IVTV_VERSION);
+ printk(KERN_INFO "ivtv: version %s loading\n", IVTV_VERSION);
memset(ivtv_cards, 0, sizeof(ivtv_cards));
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ivtv: don't recompile needlessly
2007-07-17 11:47 [PATCH] ivtv: don't recompile needlessly Alexey Dobriyan
@ 2007-07-17 12:03 ` Hans Verkuil
2007-07-17 15:26 ` Roland Dreier
1 sibling, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2007-07-17 12:03 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: akpm, v4l-dvb-maintainer, linux-kernel, hverkuil
> Driver prints 3l33t banner including kernel version.
> Could we _please_ never do this in future.
Thanks for reporting this. This was a leftover from when the driver was
standalone. I've merged this patch in my repository and will push it
upstream.
Regards,
Hans
>
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
> ---
>
> drivers/media/video/ivtv/ivtv-driver.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/drivers/media/video/ivtv/ivtv-driver.c
> +++ b/drivers/media/video/ivtv/ivtv-driver.c
> @@ -56,7 +56,6 @@
> #include "ivtv-gpio.h"
> #include "ivtv-yuv.h"
>
> -#include <linux/vermagic.h>
> #include <media/tveeprom.h>
> #include <media/v4l2-chip-ident.h>
>
> @@ -1315,7 +1314,7 @@ static struct pci_driver ivtv_pci_driver = {
> static int module_start(void)
> {
> printk(KERN_INFO "ivtv: ==================== START INIT IVTV
> ====================\n");
> - printk(KERN_INFO "ivtv: version %s (" VERMAGIC_STRING ") loading\n",
> IVTV_VERSION);
> + printk(KERN_INFO "ivtv: version %s loading\n", IVTV_VERSION);
>
> memset(ivtv_cards, 0, sizeof(ivtv_cards));
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ivtv: don't recompile needlessly
2007-07-17 11:47 [PATCH] ivtv: don't recompile needlessly Alexey Dobriyan
2007-07-17 12:03 ` Hans Verkuil
@ 2007-07-17 15:26 ` Roland Dreier
1 sibling, 0 replies; 3+ messages in thread
From: Roland Dreier @ 2007-07-17 15:26 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: akpm, v4l-dvb-maintainer, linux-kernel, hverkuil
> printk(KERN_INFO "ivtv: ==================== START INIT IVTV ====================\n");
This also looks pretty useless and way too garish given the fact that
it contains no information not already given by the next line printed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-17 15:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-17 11:47 [PATCH] ivtv: don't recompile needlessly Alexey Dobriyan
2007-07-17 12:03 ` Hans Verkuil
2007-07-17 15:26 ` Roland Dreier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox