* [PATCH 2.6.21-rc2] iw_cxgb3: Start ep timer on a MPA reject.
@ 2007-03-05 23:32 Steve Wise
2007-03-06 19:47 ` [ofa-general] " Roland Dreier
0 siblings, 1 reply; 2+ messages in thread
From: Steve Wise @ 2007-03-05 23:32 UTC (permalink / raw)
To: Roland Dreier; +Cc: linux-kernel, General
Start ep timer on a MPA reject.
If the consumer rejects the connection we end up under-referencing the
endpoint structure. The fix is to call iwch_ep_disconnect() instead of
the low level disconnect functions so that the endpoint close timer is
started correctly.
Signed-off-by: Steve Wise <swise@opengridcomputing.com>
---
drivers/infiniband/hw/cxgb3/iwch_cm.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
index fd2f3ca..d0ed1d3 100644
--- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
+++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
@@ -1691,12 +1691,11 @@ int iwch_reject_cr(struct iw_cm_id *cm_i
return -ECONNRESET;
}
BUG_ON(state_read(&ep->com) != MPA_REQ_RCVD);
- state_set(&ep->com, CLOSING);
if (mpa_rev == 0)
abort_connection(ep, NULL, GFP_KERNEL);
else {
err = send_mpa_reject(ep, pdata, pdata_len);
- err = send_halfclose(ep, GFP_KERNEL);
+ err = iwch_ep_disconnect(ep, 0, GFP_KERNEL);
}
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [ofa-general] [PATCH 2.6.21-rc2] iw_cxgb3: Start ep timer on a MPA reject.
2007-03-05 23:32 [PATCH 2.6.21-rc2] iw_cxgb3: Start ep timer on a MPA reject Steve Wise
@ 2007-03-06 19:47 ` Roland Dreier
0 siblings, 0 replies; 2+ messages in thread
From: Roland Dreier @ 2007-03-06 19:47 UTC (permalink / raw)
To: Steve Wise; +Cc: linux-kernel, General
Thanks, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-06 19:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-05 23:32 [PATCH 2.6.21-rc2] iw_cxgb3: Start ep timer on a MPA reject Steve Wise
2007-03-06 19:47 ` [ofa-general] " Roland Dreier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox