From: Roland Dreier <rdreier@cisco.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org
Subject: [PATCH] x86: Don't print number of MCE banks for every CPU
Date: Thu, 15 Oct 2009 14:21:14 -0700 [thread overview]
Message-ID: <adaeip473qt.fsf@cisco.com> (raw)
The MCE initialization code explicitly says it doesn't handle asymmetric
configurations where different CPUs support different numbers of MCE
banks, and it prints a big warning in that case. Therefore, printing
the "mce: CPU supports <x> MCE banks" message into the kernel log for
every CPU is pure redundancy that clutters the log significantly for
systems with lots of CPUs.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
arch/x86/kernel/cpu/mcheck/mce.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index b1598a9..721a77c 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -1214,7 +1214,8 @@ static int __cpuinit mce_cap_init(void)
rdmsrl(MSR_IA32_MCG_CAP, cap);
b = cap & MCG_BANKCNT_MASK;
- printk(KERN_INFO "mce: CPU supports %d MCE banks\n", b);
+ if (!banks)
+ printk(KERN_INFO "mce: CPU supports %d MCE banks\n", b);
if (b > MAX_NR_BANKS) {
printk(KERN_WARNING
next reply other threads:[~2009-10-15 21:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 21:21 Roland Dreier [this message]
2009-10-16 7:20 ` [PATCH] x86: Don't print number of MCE banks for every CPU Ingo Molnar
2009-10-16 7:22 ` [tip:x86/urgent] " tip-bot for Roland Dreier
2009-10-27 19:42 ` [PATCH] " Mike Travis
2009-10-27 20:53 ` Mike Travis
2009-10-28 4:07 ` [PATCH] x86, mce: disable MCE if cpu has no MCE banks Hidetoshi Seto
2009-10-28 5:24 ` Andi Kleen
2009-10-28 6:26 ` Hidetoshi Seto
2009-10-28 6:48 ` Andi Kleen
2009-10-28 8:18 ` Hidetoshi Seto
2009-10-28 17:09 ` Mike Travis
2009-10-28 17:12 ` Roland Dreier
2009-10-28 17:37 ` Mike Travis
2009-10-28 18:03 ` Roland Dreier
2009-10-28 12:03 ` Valdis.Kletnieks
2009-10-28 13:44 ` Andi Kleen
2009-10-28 4:26 ` [PATCH] x86: Don't print number of MCE banks for every CPU Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaeip473qt.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox