From: Roland Dreier <rdreier@cisco.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
shaohua.li@intel.com, lhcs-devel@lists.sourceforge.net
Subject: Re: [PATCH 4/7] SMP: Implement on_one_cpu()
Date: Thu, 24 May 2007 06:43:32 -0700 [thread overview]
Message-ID: <adaejl68hh7.fsf@cisco.com> (raw)
In-Reply-To: <11800086152009-git-send-email-avi@qumranet.com> (Avi Kivity's message of "Thu, 24 May 2007 15:10:12 +0300")
I don't see any documented restrictions about preemption being
disabled when this function is called, but...
> +int on_one_cpu(int cpu, void (*func) (void *info), void *info,
> + int retry, int wait)
> +{
> + int ret;
> + int this_cpu;
> +
> + this_cpu = get_cpu();
what if a preempt and reschedule to a different CPU happens right
here, after this_cpu is set?
> + if (this_cpu == cpu) {
next prev parent reply other threads:[~2007-05-24 13:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 12:10 [PATCH 0/7] KVM: Suspend and cpu hotplug fixes Avi Kivity
2007-05-24 12:10 ` [PATCH 1/7] HOTPLUG: Add CPU_DYING notifier Avi Kivity
2007-05-24 12:10 ` [PATCH 2/7] HOTPLUG: Adapt cpuset hotplug callback to CPU_DYING Avi Kivity
2007-05-24 12:10 ` [PATCH 3/7] HOTPLUG: Adapt thermal throttle " Avi Kivity
2007-05-24 12:10 ` [PATCH 4/7] SMP: Implement on_one_cpu() Avi Kivity
2007-05-24 13:36 ` [kvm-devel] " Heiko Carstens
2007-05-24 13:42 ` Avi Kivity
2007-05-24 13:43 ` Roland Dreier [this message]
2007-05-24 13:48 ` Avi Kivity
2007-05-24 12:10 ` [PATCH 5/7] KVM: Keep track of which cpus have virtualization enabled Avi Kivity
2007-05-24 12:10 ` [PATCH 6/7] KVM: Tune hotplug/suspend IPIs Avi Kivity
2007-05-24 12:10 ` [PATCH 7/7] KVM: Use CPU_DYING for disabling virtualization Avi Kivity
2007-05-24 12:53 ` [kvm-devel] [PATCH 0/7] KVM: Suspend and cpu hotplug fixes Avi Kivity
2007-05-25 1:10 ` Shaohua Li
2007-05-25 8:28 ` Avi Kivity
2007-05-27 10:20 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaejl68hh7.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=lhcs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox