Re: [kvm-devel] [PATCH 4/7] SMP: Implement on_one_cpu()

Heiko Carstens
2007-05-24T13:37:18Z

On Thu, May 24, 2007 at 03:10:12PM +0300, Avi Kivity wrote:
> This defines on_one_cpu() which is similar to smp_call_function_single()
> except that it works if cpu happens to be the current cpu. Can also be
> seen as a complement to on_each_cpu() (which also doesn't treat the
> current cpu specially).
>
> Signed-off-by: Avi Kivity <avi@qumranet.com>
> ---
> include/linux/smp.h | 15 +++++++++++++++
> kernel/softirq.c | 24 ++++++++++++++++++++++++
> 2 files changed, 39 insertions(+), 0 deletions(-)
>
> +/*
> + * Call a function on one processor
> + */
> +int on_one_cpu(int cpu, void (*func)(void *info), void *info,
> + int retry, int wait);
>

Would you mind renaming that one to simply 'on_cpu'? It's even shorter and
clearly everybody will know what its purpose is. Also I doubt we will ever
have something like 'on_two_cpus'.