public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: "Or Gerlitz" <or.gerlitz@gmail.com>
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org,
	michaelc@cs.wisc.edu, James.Bottomley@SteelEye.com
Subject: Re: [openib-general] [PATCH 6/6] iSER Kconfig and Makefile
Date: Thu, 11 May 2006 11:29:06 -0700	[thread overview]
Message-ID: <adaejz01klp.fsf@cisco.com> (raw)
In-Reply-To: <15ddcffd0605111124v390e1dbei18508787ec29afac@mail.gmail.com> (Or Gerlitz's message of "Thu, 11 May 2006 20:24:09 +0200")

    Or> Indeed since libiscsi does not have a CONFIG_ of its own, you
    Or> need to set CONFIG_ISCSI_TCP to have libiscsi being built and
    Or> then iser links with it.

    Or> So there are two options here: either to set a CONFIG_LIBISCSI
    Or> and select it by both CONFIG_ISCSI_TCP and
    Or> CONFIG_INFINIBAND_ISER or the approach you were suggesting. I
    Or> am cc-ing Mike Christie and James Bottomley on this email, if
    Or> you guys have a preference, let me know and i can produce a
    Or> patch to drivers/scsi/Kconfig and Makefile.

In the iser branch of my git tree I just added

    obj-$(CONFIG_INFINIBAND_ISER)   += libiscsi.o

to drivers/scsi/Makefile.  So let me know if I should change that.

    Or> Thanks to you for pointing these issues, also, in
    Or> drivers/infiniband/Makefile

    >> +obj-$(CONFIG_INFINIBAND_SRP) += ulp/iser/

    Or> should be

    >> +obj-$(CONFIG_INFINIBAND_ISER) += ulp/iser/

Thanks, I made a copy-and-paste error there.  I pushed out a fixed tree.

 - R.

      reply	other threads:[~2006-05-11 18:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-11  6:59 [PATCH 0/6] iSER (iSCSI Extensions for RDMA) initiator Or Gerlitz
2006-05-11  7:00 ` [PATCH 1/6] iSCSI iSER transport provider header file Or Gerlitz
2006-05-11  7:00   ` [PATCH 2/6] iSCSI iSER transport provider high level code Or Gerlitz
2006-05-11  7:02     ` [PATCH 3/6] iSER initiator iSCSI PDU and TX/RX completions processing Or Gerlitz
2006-05-11  7:02       ` [PATCH 4/6] iSER RDMA CM (CMA) and IB verbs interaction Or Gerlitz
2006-05-11  7:03         ` [PATCH 5/6] iSER handling of memory for RDMA Or Gerlitz
2006-05-11  7:03           ` [PATCH 6/6] iSER Kconfig and Makefile Or Gerlitz
2006-05-11 17:24             ` [openib-general] " Roland Dreier
2006-05-11 18:24               ` Or Gerlitz
2006-05-11 18:29                 ` Roland Dreier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adaejz01klp.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=openib-general@openib.org \
    --cc=or.gerlitz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox