From: Roland Dreier <rdreier@cisco.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-pci <linux-pci@atrey.karlin.mff.cuni.cz>
Subject: Re: MSI and driver APIs
Date: Thu, 15 Dec 2005 13:18:04 -0800 [thread overview]
Message-ID: <adaek4enjoz.fsf@cisco.com> (raw)
In-Reply-To: <1134680882.16880.37.camel@gaston> (Benjamin Herrenschmidt's message of "Fri, 16 Dec 2005 08:08:02 +1100")
Benjamin> You can have multiple MSIs too (they just have to be
Benjamin> contiguous in numbers and aligned on the nearest power
Benjamin> of 2).
Good point. I just got too used to the x86-ism of the current MSI
code, which can't handle allocating contiguous vectors.
Benjamin> I'm tempted to leave them enabled and only disable them
Benjamin> when request_irq() is done on the legacy INTx... Does
Benjamin> anybody see a problem with this approach ?
You might run into trouble on hardware (think tg3 or its ilk again)
where you might have to do something beyond disabling MSI in the PCI
header to switch the chip out of MSI mode.
- R.
next prev parent reply other threads:[~2005-12-15 21:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-15 3:38 MSI and driver APIs Benjamin Herrenschmidt
2005-12-15 21:07 ` Roland Dreier
2005-12-15 21:08 ` Benjamin Herrenschmidt
2005-12-15 21:18 ` Roland Dreier [this message]
2005-12-15 21:18 ` Benjamin Herrenschmidt
2005-12-15 21:36 ` Roland Dreier
2005-12-15 21:42 ` David S. Miller
2005-12-15 21:56 ` Benjamin Herrenschmidt
2005-12-16 0:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaek4enjoz.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox