From: Roland Dreier <rdreier@cisco.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>,
David Woodhouse <David.Woodhouse@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] intel-iommu: Make "Unknown DMAR structure" message more informative
Date: Wed, 23 Sep 2009 17:01:29 -0700 [thread overview]
Message-ID: <adafxad2oti.fsf@cisco.com> (raw)
We might as well print the type of the DMAR structure we don't know how
to handle when skipping it. Then someone getting this message has a
chance of telling whether the structure is just bogus, or if there
really is something valid that the kernel doesn't know how to handle.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
drivers/pci/dmar.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
index 14bbaa1..d199bca 100644
--- a/drivers/pci/dmar.c
+++ b/drivers/pci/dmar.c
@@ -461,7 +461,8 @@ parse_dmar_table(void)
break;
default:
printk(KERN_WARNING PREFIX
- "Unknown DMAR structure type\n");
+ "Unknown DMAR structure type %d\n",
+ entry_header->type);
ret = 0; /* for forward compatibility */
break;
}
reply other threads:[~2009-09-24 0:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adafxad2oti.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=David.Woodhouse@intel.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox