Re: [PATCH] [13/16] POISON: The high level memory error handler in the VM

Andi Kleen
2009-04-07T16:28:59Z

On Tue, Apr 07, 2009 at 12:03:00PM -0400, Rik van Riel wrote:
> Andi Kleen wrote:
>
> >This is rather tricky code and needs a lot of review. Undoubtedly it still
> >has bugs.
>
> It's just complex enough that it looks like it might have
> more bugs, but I sure couldn't find any.

Thanks for the review.

Perhaps I didn't put it strongly enough: I know there are still bugs
in there (e.g. nonlinear mappings deadlock and there are some cases
where the reference count of the page doesn't drop the zero).

> Hitting a bug in this code seems favorable to hitting
> guaranteed memory corruption, so I hope Andrew or Ingo

Yes the alternative is always panic() when the hardware detects
the consumed corruption and bails out. So even if this code is buggy it's
very likely still an improvement. So it would be reasonable to
do a relatively early merge and improve further in tree.

> >Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> Acked-by: Rik van Riel <riel@redhat.com>

Thanks added

-Andi

--
ak@linux.intel.com -- Speaking for myself only.