* [PATCH 1/5] drivers/infiniband/hw: Drop code after return
@ 2008-09-11 12:33 Julia Lawall
2008-09-11 13:46 ` Richard Genoud
2008-09-16 17:23 ` Roland Dreier
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2008-09-11 12:33 UTC (permalink / raw)
To: rolandd, sean.hefty, hal.rosenstock, general, vigneshbabu,
richard.genoud, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The break after the return serves no purpose.
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/infiniband/hw/amso1100/c2_provider.c | 1 -
drivers/infiniband/hw/nes/nes_verbs.c | 3 ---
2 files changed, 4 deletions(-)
diff -u -p a/drivers/infiniband/hw/amso1100/c2_provider.c b/drivers/infiniband/hw/amso1100/c2_provider.c
--- a/drivers/infiniband/hw/amso1100/c2_provider.c
+++ b/drivers/infiniband/hw/amso1100/c2_provider.c
@@ -272,7 +272,6 @@ static struct ib_qp *c2_create_qp(struct
pr_debug("%s: Invalid QP type: %d\n", __func__,
init_attr->qp_type);
return ERR_PTR(-EINVAL);
- break;
}
if (err) {
diff -u -p a/drivers/infiniband/hw/nes/nes_verbs.c b/drivers/infiniband/hw/nes/nes_verbs.c
--- a/drivers/infiniband/hw/nes/nes_verbs.c
+++ b/drivers/infiniband/hw/nes/nes_verbs.c
@@ -1467,7 +1467,6 @@ static struct ib_qp *nes_create_qp(struc
default:
nes_debug(NES_DBG_QP, "Invalid QP type: %d\n", init_attr->qp_type);
return ERR_PTR(-EINVAL);
- break;
}
/* update the QP table */
@@ -2498,7 +2497,6 @@ static struct ib_mr *nes_reg_user_mr(str
nes_debug(NES_DBG_MR, "Leaving, ibmr=%p", ibmr);
return ibmr;
- break;
case IWNES_MEMREG_TYPE_QP:
case IWNES_MEMREG_TYPE_CQ:
nespbl = kzalloc(sizeof(*nespbl), GFP_KERNEL);
@@ -2572,7 +2570,6 @@ static struct ib_mr *nes_reg_user_mr(str
nesmr->ibmr.lkey = -1;
nesmr->mode = req.reg_type;
return &nesmr->ibmr;
- break;
}
return ERR_PTR(-ENOSYS);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/5] drivers/infiniband/hw: Drop code after return
2008-09-11 12:33 [PATCH 1/5] drivers/infiniband/hw: Drop code after return Julia Lawall
@ 2008-09-11 13:46 ` Richard Genoud
2008-09-16 17:23 ` Roland Dreier
1 sibling, 0 replies; 3+ messages in thread
From: Richard Genoud @ 2008-09-11 13:46 UTC (permalink / raw)
To: Julia Lawall
Cc: rolandd, sean.hefty, hal.rosenstock, general, vigneshbabu,
linux-kernel, kernel-janitors
2008/9/11 Julia Lawall <julia@diku.dk>:
> From: Julia Lawall <julia@diku.dk>
>
> The break after the return serves no purpose.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
> ---
> drivers/infiniband/hw/amso1100/c2_provider.c | 1 -
> drivers/infiniband/hw/nes/nes_verbs.c | 3 ---
> 2 files changed, 4 deletions(-)
>
> diff -u -p a/drivers/infiniband/hw/amso1100/c2_provider.c b/drivers/infiniband/hw/amso1100/c2_provider.c
> --- a/drivers/infiniband/hw/amso1100/c2_provider.c
> +++ b/drivers/infiniband/hw/amso1100/c2_provider.c
> @@ -272,7 +272,6 @@ static struct ib_qp *c2_create_qp(struct
> pr_debug("%s: Invalid QP type: %d\n", __func__,
> init_attr->qp_type);
> return ERR_PTR(-EINVAL);
> - break;
> }
>
> if (err) {
> diff -u -p a/drivers/infiniband/hw/nes/nes_verbs.c b/drivers/infiniband/hw/nes/nes_verbs.c
> --- a/drivers/infiniband/hw/nes/nes_verbs.c
> +++ b/drivers/infiniband/hw/nes/nes_verbs.c
> @@ -1467,7 +1467,6 @@ static struct ib_qp *nes_create_qp(struc
> default:
> nes_debug(NES_DBG_QP, "Invalid QP type: %d\n", init_attr->qp_type);
> return ERR_PTR(-EINVAL);
> - break;
> }
>
> /* update the QP table */
> @@ -2498,7 +2497,6 @@ static struct ib_mr *nes_reg_user_mr(str
> nes_debug(NES_DBG_MR, "Leaving, ibmr=%p", ibmr);
>
> return ibmr;
> - break;
> case IWNES_MEMREG_TYPE_QP:
> case IWNES_MEMREG_TYPE_CQ:
> nespbl = kzalloc(sizeof(*nespbl), GFP_KERNEL);
> @@ -2572,7 +2570,6 @@ static struct ib_mr *nes_reg_user_mr(str
> nesmr->ibmr.lkey = -1;
> nesmr->mode = req.reg_type;
> return &nesmr->ibmr;
> - break;
> }
>
> return ERR_PTR(-ENOSYS);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/5] drivers/infiniband/hw: Drop code after return
2008-09-11 12:33 [PATCH 1/5] drivers/infiniband/hw: Drop code after return Julia Lawall
2008-09-11 13:46 ` Richard Genoud
@ 2008-09-16 17:23 ` Roland Dreier
1 sibling, 0 replies; 3+ messages in thread
From: Roland Dreier @ 2008-09-16 17:23 UTC (permalink / raw)
To: Julia Lawall
Cc: rolandd, sean.hefty, hal.rosenstock, general, vigneshbabu,
richard.genoud, linux-kernel, kernel-janitors
thanks, applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-16 17:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-11 12:33 [PATCH 1/5] drivers/infiniband/hw: Drop code after return Julia Lawall
2008-09-11 13:46 ` Richard Genoud
2008-09-16 17:23 ` Roland Dreier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox