From: Roland Dreier <rdreier@cisco.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Aleksey Senin <alekseys@voltaire.com>,
"general\@lists.openfabrics.org" <general@lists.openfabrics.org>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: linux-next: origin tree build failure
Date: Mon, 29 Dec 2008 13:35:02 -0800 [thread overview]
Message-ID: <adahc4mu0l5.fsf@cisco.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0812291304471.3082@localhost.localdomain> (Linus Torvalds's message of "Mon, 29 Dec 2008 13:07:16 -0800 (PST)")
> I'd suggest
>
> config IF_IPV6
> bool
> depends on INET
> depends on !(INFINIBAND = y && IPV6 = m)
> default y
Makes sense, will do. How about calling it INFINIBAND_USE_IPV6 or
something like that, though? (Since it's under the INFINIBAND config
stuff and exists to forbid INFINIBAND=y && IPV6=m trying to use IPv6).
But see below:
> but also use it in the source code as a more readable version:
>
> > diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
> > index d98b05b..ec7abb5 100644
> > --- a/drivers/infiniband/core/addr.c> +++ b/drivers/infiniband/core/addr.c
> > @@ -128,6 +128,7 @@ int rdma_translate_ip(struct sockaddr *addr, struct rdma_dev_addr *dev_addr)
> > ret = rdma_copy_addr(dev_addr, dev, NULL);
> > dev_put(dev);
> > break;
> > +#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
>
> ie use
>
> #ifdef CONFIG_IF_IPV6
this doesn't make sense, does it? Your CONFIG_IF_IPV6 will be set in
the case IPV6=n too I think. (Which is the whole point... we want to
build this code, just without IPv6 support, if IPv6 is turned off
completely)
- R.
next prev parent reply other threads:[~2008-12-29 21:35 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 0:43 linux-next: origin tree build failure Stephen Rothwell
2008-12-29 3:36 ` Roland Dreier
2008-12-29 3:44 ` Roland Dreier
2008-12-29 9:58 ` Aleksey Senin
2008-12-29 16:13 ` Roland Dreier
2008-12-29 16:52 ` Aleksey Senin
2008-12-29 20:18 ` Roland Dreier
2008-12-29 21:07 ` Linus Torvalds
2008-12-29 21:35 ` Roland Dreier [this message]
2008-12-29 21:48 ` [ofa-general] " Roland Dreier
2008-12-29 8:48 ` Aleksey Senin
2008-12-30 7:38 ` Roland Dreier
2008-12-30 8:30 ` Stephen Rothwell
2008-12-30 15:41 ` [ofa-general] " Roland Dreier
2008-12-30 15:46 ` Stephen Rothwell
2008-12-30 22:52 ` Stephen Rothwell
2008-12-30 22:56 ` Roland Dreier
2008-12-30 23:17 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2010-01-12 1:14 Stephen Rothwell
2010-01-12 1:26 ` Linus Torvalds
2010-01-12 2:32 ` Stephen Rothwell
2010-01-12 2:39 ` Stephen Rothwell
2010-01-13 0:14 ` Phillip Lougher
2010-01-13 2:55 ` Stephen Rothwell
2010-01-11 23:58 Stephen Rothwell
2010-01-12 0:29 ` Joakim Tjernlund
2010-01-12 12:38 ` Joakim Tjernlund
2009-12-24 0:54 Stephen Rothwell
2009-12-15 5:41 Stephen Rothwell
2009-12-15 8:07 ` Ingo Molnar
2009-12-15 13:01 ` Peter Ujfalusi
2009-12-15 14:53 ` Mark Brown
2009-12-15 17:27 ` Tony Lindgren
2009-12-15 22:45 ` Stephen Rothwell
2009-12-15 23:02 ` Linus Torvalds
2009-12-15 23:37 ` Stephen Rothwell
2009-12-16 9:30 ` Samuel Ortiz
2009-12-09 23:57 Stephen Rothwell
2009-11-30 23:10 Stephen Rothwell
2009-11-12 0:23 Stephen Rothwell
2009-10-09 7:50 Stephen Rothwell
2009-07-09 0:28 Stephen Rothwell
2009-06-25 1:13 Stephen Rothwell
2009-06-25 3:24 ` Baruch Siach
2009-06-25 4:12 ` Paul Mundt
2009-06-23 6:22 Stephen Rothwell
2009-06-23 10:13 ` Mark Brown
2009-06-19 6:30 Stephen Rothwell
2009-06-12 0:46 Stephen Rothwell
2009-06-12 0:24 Stephen Rothwell
2009-06-12 0:53 ` Paul Mackerras
2009-06-12 1:00 ` Benjamin Herrenschmidt
2009-06-12 9:20 ` Ingo Molnar
2009-06-12 9:33 ` Benjamin Herrenschmidt
2009-06-12 9:43 ` Peter Zijlstra
2009-06-12 9:55 ` Ingo Molnar
2009-06-12 9:57 ` Benjamin Herrenschmidt
2009-06-12 12:53 ` Ingo Molnar
2009-06-12 13:10 ` Benjamin Herrenschmidt
2009-06-12 13:29 ` Benjamin Herrenschmidt
2009-06-12 13:49 ` Ingo Molnar
2009-06-12 14:06 ` Benjamin Herrenschmidt
2009-06-12 14:11 ` Ingo Molnar
2009-06-12 14:23 ` Benjamin Herrenschmidt
2009-06-13 5:06 ` Stephen Rothwell
2009-06-12 13:44 ` Ingo Molnar
2009-06-12 13:56 ` Benjamin Herrenschmidt
2009-06-12 14:07 ` Ingo Molnar
2009-06-12 14:19 ` Benjamin Herrenschmidt
2009-06-13 4:54 ` Stephen Rothwell
2009-04-14 7:34 Stephen Rothwell
2009-04-14 7:58 ` Jesper Nilsson
2009-04-14 4:43 Stephen Rothwell
2009-04-14 8:57 ` David Miller
2009-04-14 9:20 ` Heiko Carstens
2009-04-14 9:08 ` David Miller
2009-04-14 10:26 ` Stephen Rothwell
2009-04-08 3:28 Stephen Rothwell
2009-04-08 0:10 Stephen Rothwell
2009-03-30 0:55 Stephen Rothwell
2009-01-11 23:48 Stephen Rothwell
2009-01-12 0:10 ` Benjamin Herrenschmidt
2009-01-12 9:05 ` Ingo Molnar
2009-01-12 9:24 ` Stephen Rothwell
2009-01-12 9:32 ` Ingo Molnar
2009-01-13 16:31 ` Stephen Rothwell
2009-01-12 9:49 ` Michael Ellerman
2009-01-12 10:44 ` Ingo Molnar
2008-12-29 0:00 Stephen Rothwell
2008-12-28 23:51 Stephen Rothwell
2008-12-28 23:38 Stephen Rothwell
2008-12-29 0:31 ` Linus Torvalds
2008-10-16 0:31 Stephen Rothwell
2008-10-16 12:58 ` Ralf Baechle
2008-10-14 22:59 Stephen Rothwell
2008-10-14 23:43 ` Linus Torvalds
2008-10-14 23:52 ` David Miller
2008-10-15 0:05 ` Mark Brown
2008-10-15 0:34 ` Linus Torvalds
2008-10-14 23:51 ` Linus Torvalds
2008-10-15 9:02 ` Alan Cox
2008-10-15 9:33 ` Ingo Molnar
2008-10-15 11:01 ` Mark Brown
2008-08-26 0:37 Stephen Rothwell
2008-08-18 0:01 Stephen Rothwell
2008-08-18 12:55 ` David Howells
2008-08-18 14:03 ` James Morris
2008-07-25 0:30 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adahc4mu0l5.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=alekseys@voltaire.com \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox