From: Roland Dreier <rdreier@cisco.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jiri Slaby <jirislaby@gmail.com>,
linux-kernel@vger.kernel.org, Eli Cohen <eli@dev.mellanox.co.il>,
general@lists.openfabrics.org, Oleg Nesterov <oleg@tv-sign.ru>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: wait_for_completion_timeout() spurious failure under heavy load?
Date: Fri, 20 Jun 2008 07:33:02 -0700 [thread overview]
Message-ID: <adahcbotbvl.fsf@cisco.com> (raw)
In-Reply-To: <20080620112042.GE7439@elte.hu> (Ingo Molnar's message of "Fri, 20 Jun 2008 13:20:42 +0200")
> but like in the commit below. Agreed?
> +
> + /*
> + * If the completion has arrived meanwhile
> + * then return 1 jiffy time left:
> + */
> + if (x->done && !timeout) {
> + timeout = 1;
> + break;
> + }
> +
Sure, that looks nice to me.
- R.
prev parent reply other threads:[~2008-06-20 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 22:04 wait_for_completion_timeout() spurious failure under heavy load? Roland Dreier
2008-06-20 6:40 ` Jiri Slaby
2008-06-20 11:20 ` Ingo Molnar
2008-06-20 11:30 ` Peter Zijlstra
2008-06-20 14:14 ` Oleg Nesterov
2008-06-20 14:32 ` Oleg Nesterov
2008-06-20 15:21 ` Ingo Molnar
2008-06-20 14:33 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adahcbotbvl.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=a.p.zijlstra@chello.nl \
--cc=eli@dev.mellanox.co.il \
--cc=general@lists.openfabrics.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox