From: Roland Dreier <rdreier@cisco.com>
To: corbet@lwn.net (Jonathan Corbet)
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Alexander Viro <viro@ftp.linux.org.uk>,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH, RFC] Char dev BKL pushdown v2
Date: Mon, 19 May 2008 13:38:48 -0700 [thread overview]
Message-ID: <adahccu6nc7.fsf@cisco.com> (raw)
In-Reply-To: <12244.1211204278@vena.lwn.net> (Jonathan Corbet's message of "Mon, 19 May 2008 07:37:58 -0600")
> If you're sure that this code doesn't need the BKL (and it kind of
> looked that way to me), the preferred approach seems to be to put in a
> comment to that effect so that it's clear that the code has been looked
> at. So sending me a patch which does this would be great.
OK, will send such a patch after auditing more carefully. Just to be
very clear, the issue is to make sure the locking is sufficient to
protect against multiple racing open calls to the same character device?
- R.
next prev parent reply other threads:[~2008-05-19 20:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-18 22:15 [PATCH, RFC] Char dev BKL pushdown v2 Jonathan Corbet
2008-05-19 4:00 ` Roland Dreier
2008-05-19 13:37 ` Jonathan Corbet
2008-05-19 20:38 ` Roland Dreier [this message]
2008-05-19 20:42 ` Jonathan Corbet
2008-05-19 22:18 ` Roland Dreier
2008-05-19 22:56 ` Jonathan Corbet
2008-05-20 2:10 ` Jeff Dike
2008-05-20 8:26 ` Alan Cox
2008-05-19 4:03 ` Stephen Rothwell
2008-05-19 13:46 ` Jonathan Corbet
2008-05-19 13:17 ` Ingo Molnar
2008-05-19 17:46 ` Stefan Richter
2008-05-19 19:27 ` Stefan Richter
2008-05-19 20:07 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adahccu6nc7.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox