From: Roland Dreier <rdreier@cisco.com>
To: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@elte.hu
Subject: Build failure (with insane config)
Date: Sun, 27 Apr 2008 20:34:12 -0700 [thread overview]
Message-ID: <adahcdm3b63.fsf@cisco.com> (raw)
For x86-64, arch/x86/lib/Makefile has:
lib-y += csum-partial_64.o csum-copy_64.o csum-wrappers_64.o
so in particular ip_compute_csum() (from csum-partial_64.c) gets put in
libs, so even though it is exported, it gets thrown away at link time if
there are no non-modular users.
However, if someone has an insane config with CONFIG_NET=n and
CONFIG_VIDEO_BT848=m, then ip_compute_csum() gets discarded but the
modular code in drivers/media/video/bt8xx/bttv-cards.c calls it and...
ERROR: "ip_compute_csum" [drivers/media/video/bt8xx/bttv.ko] undefined!
I guess one fix is just to put at least csum-partial_64.c in obj-y
instead; it does seem broken to have files with EXPORT_SYMBOL() be
lib-y, since it is really an invitation for this problem. Other ideas
would be for bttv to depend on or select CONFIG_NET.
[It's a long story why I noticed this problem, but maybe we want to fix
it to save people doing randconfig test builds or something like that.
Or maybe we don't really care, since the class of real systems with
video capture cards but no networking is probably quite small]
- R.
next reply other threads:[~2008-04-28 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 3:34 Roland Dreier [this message]
2008-04-28 8:08 ` Build failure (with insane config) Ingo Molnar
2008-04-28 9:30 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adahcdm3b63.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox