public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: riku.voipio@iki.fi, rpurdie@rpsys.net,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] leds: always true: (x != 1 || x != 2)
Date: Fri, 06 Feb 2009 10:05:57 -0800	[thread overview]
Message-ID: <adaiqnnxwxm.fsf@cisco.com> (raw)
In-Reply-To: <498863FC.1090008@gmail.com> (Roel Kluin's message of "Tue, 03 Feb 2009 16:34:20 +0100")

 > -	if (type != EV_SND && (code != SND_BELL || code != SND_TONE))
 > +	if (type != EV_SND && (code != SND_BELL && code != SND_TONE))

Actually more likely seems to be

	if (type != EV_SND || (code != SND_BELL && code != SND_TONE))

  reply	other threads:[~2009-02-06 18:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-03 15:34 [PATCH] leds: always true: (x != 1 || x != 2) Roel Kluin
2009-02-06 18:05 ` Roland Dreier [this message]
2009-02-06 18:51   ` [PATCH v2] leds: Fix &&/|| confusion Roel Kluin
2009-03-03 20:13     ` Riku Voipio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adaiqnnxwxm.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riku.voipio@iki.fi \
    --cc=roel.kluin@gmail.com \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox