The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Nick Piggin <npiggin@suse.de>
Cc: linux-kernel@vger.kernel.org,
	"Hugh Dickins <hugh@veritas.com> Andrew Morton" 
	<akpm@linux-foundation.org>,
	"Torvalds@linux-foundation.org Torvalds" 
	<torvalds@linux-foundation.org>
Subject: CONFIG_SWAP=n broken in latest tree
Date: Wed, 14 Feb 2007 14:41:05 -0800	[thread overview]
Message-ID: <adak5ykz7jy.fsf@cisco.com> (raw)

Commit 42da9cbd ("mm: mincore anon") breaks CONFIG_SWAP=n builds with:

    mm/built-in.o: In function `sys_mincore':
    (.text+0xe2c4): undefined reference to `swapper_space'

because swapper_space is used unconditionally in mm/mincore.c but only
defined in swap_state.c, which isn't built if CONFIG_SWAP=n.

I'd include a patch but I'm not sure what the right fix is really --
the naively obvious thing to do would be to add an #ifdef to mincore.c
like the below, but I don't know this area at all well enough to be
confident in the fix.

diff --git a/mm/mincore.c b/mm/mincore.c
index 95c5f49..266506f 100644
--- a/mm/mincore.c
+++ b/mm/mincore.c
@@ -109,8 +109,9 @@ static long do_mincore(unsigned long addr, unsigned char *vec, unsigned long pag
 		} else if (pte_file(pte)) {
 			pgoff = pte_to_pgoff(pte);
 			present = mincore_page(vma->vm_file->f_mapping, pgoff);
-
-		} else { /* pte is a swap entry */
+		}
+#ifdef CONFIG_SWAP
+		else { /* pte is a swap entry */
 			swp_entry_t entry = pte_to_swp_entry(pte);
 			if (is_migration_entry(entry)) {
 				/* migration entries are always uptodate */
@@ -120,6 +121,7 @@ static long do_mincore(unsigned long addr, unsigned char *vec, unsigned long pag
 				present = mincore_page(&swapper_space, pgoff);
 			}
 		}
+#endif /* CONFIG_SWAP */
 	}
 	pte_unmap_unlock(ptep-1, ptl);
 

             reply	other threads:[~2007-02-14 22:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-14 22:41 Roland Dreier [this message]
2007-02-14 22:49 ` CONFIG_SWAP=n broken in latest tree Randy Dunlap
2007-02-14 22:57   ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adak5ykz7jy.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox