From: Roland Dreier <rdreier@cisco.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH] block: Fix register_disk() when name has '/' in it
Date: Fri, 09 Jan 2009 21:57:15 -0800 [thread overview]
Message-ID: <adaljtjog90.fsf@cisco.com> (raw)
Commit 3ada8b7e ("block: struct device - replace bus_id with dev_name(),
dev_set_name()") deleted the code in register_disk() that changed a '/'
to a '!' in the device name when registering a disk. This leads to
amusing problems with disks that have '/' in their names -- for example
a failure to boot with the root partition on a cciss device, even though
the kernel says it knows about the root device:
VFS: Cannot open root device "cciss/c0d0p6" or unknown-block(0,0)
Please append a correct "root=" boot option; here are the available partitions:
6800 71652960 cciss/c0d0 driver: cciss
6802 1 cciss/c0d0p2
6805 2931831 cciss/c0d0p5
6806 34354908 cciss/c0d0p6
6810 71652960 cciss/c0d1 driver: cciss
Fix this by bringing back the code to change '/' to '!' in disk names
when registering a disk.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
fs/partitions/check.c | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/fs/partitions/check.c b/fs/partitions/check.c
index 6d72024..474d73e 100644
--- a/fs/partitions/check.c
+++ b/fs/partitions/check.c
@@ -448,11 +448,19 @@ void register_disk(struct gendisk *disk)
struct block_device *bdev;
struct disk_part_iter piter;
struct hd_struct *part;
+ char dname[DISK_NAME_LEN];
+ char *s;
int err;
ddev->parent = disk->driverfs_dev;
- dev_set_name(ddev, disk->disk_name);
+ /* ewww... some of these buggers have / in the name... */
+ strcpy(dname, disk->disk_name);
+ s = strchr(dname, '/');
+ if (s)
+ *s = '!';
+
+ dev_set_name(ddev, dname);
/* delay uevents, until we scanned partition table */
ddev->uevent_suppress = 1;
next reply other threads:[~2009-01-10 5:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 5:57 Roland Dreier [this message]
2009-01-10 6:08 ` [PATCH] block: Fix register_disk() when name has '/' in it Kay Sievers
2009-01-10 6:11 ` Roland Dreier
2009-01-10 6:18 ` Kay Sievers
2009-01-10 6:27 ` [PATCH] driver core: Convert '/' to '!' in dev_set_name() Roland Dreier
2009-01-10 6:30 ` Kay Sievers
2009-01-11 6:52 ` Roland Dreier
2009-01-11 7:31 ` Greg KH
2009-01-15 22:49 ` Roland Dreier
2009-01-15 22:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaljtjog90.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=gregkh@suse.de \
--cc=jens.axboe@oracle.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox