Re: [PATCH 4/6] myri10ge - First half of the driver

Francois Romieu
2006-05-13T16:15:32Z

Brice Goglin <brice@myri.com> :
[...]
> > Return in a middle of a spinlock-intensive function. :o(
> >
>
> What do you mean ?

It is preferred for maintenance purpose (hello Mr Morton) to organize
the control flow with a single spin_{lock/unlock} pair: if there is a
branch in the control flow, it ought to be joined again before returning.

--
Ueimor