From: Roland Dreier <rdreier@cisco.com>
To: Yegor Yefremov <yegorslists@googlemail.com>
Cc: Tiago Maluta <tiago.maluta@gmail.com>,
Michal Marek <mmarek@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Roland McGrath <roland@redhat.com>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config
Date: Thu, 05 Aug 2010 14:37:07 -0700 [thread overview]
Message-ID: <adaocdg3fng.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <AANLkTinC6Sqs7W--=14nmJFDcTS4HQn0=ysn7VhYDDX6@mail.gmail.com> (Yegor Yefremov's message of "Wed, 4 Aug 2010 14:16:15 +0200")
> What about such a solution:
>
> just remove empty CROSS_COMPILE ?=
>
> Fix CONFIG_CROSS_COMPILE issue in .config
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>
> Index: b/Makefile
> ===================================================================
> --- a/Makefile 2010-08-02 00:11:14.000000000 +0200
> +++ b/Makefile 2010-08-04 14:08:51.000000000 +0200
> @@ -189,7 +189,6 @@
> # Note: Some architectures assign CROSS_COMPILE in their arch/*/Makefile
> export KBUILD_BUILDHOST := $(SUBARCH)
> ARCH ?= $(SUBARCH)
> -CROSS_COMPILE ?=
> CROSS_COMPILE ?= $(CONFIG_CROSS_COMPILE:"%"=%)
Yes, this make sense to me. It's not clear to me why we ever needed
the conditional assignment of an empty CROSS_COMPILE (that code predates
the start of git history) but clearly having two "?=" assignments one
after another cannot work -- the second assignment to CROSS_COMPILE will
never do anything, since the line before makes CROSS_COMPILE defined.
- R.
--
Roland Dreier <rolandd@cisco.com> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
next prev parent reply other threads:[~2010-08-05 21:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 12:50 [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config Tiago Maluta
2010-06-21 19:06 ` Andrew Morton
2010-06-21 19:09 ` Roland McGrath
2010-06-21 19:54 ` Michal Marek
2010-06-23 3:44 ` Tiago Maluta
2010-08-04 12:16 ` Yegor Yefremov
2010-08-05 21:37 ` Roland Dreier [this message]
2010-08-05 22:26 ` Roland McGrath
2010-08-10 6:43 ` Yegor Yefremov
2010-08-10 7:33 ` Roland McGrath
2010-08-10 11:21 ` Michal Marek
2010-08-16 12:35 ` Andrew Hendry
2010-08-16 12:40 ` Michal Marek
2010-08-16 12:51 ` Andrew Hendry
2012-02-16 6:03 ` ramana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaocdg3fng.fsf@roland-alpha.cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=roland@redhat.com \
--cc=tiago.maluta@gmail.com \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox