[PATCH] crypto: aes-ni - Don't print message with KERN_ERR on old system

[PATCH] crypto: aes-ni - Don't print message with KERN_ERR on old system

[Roland Dreier]

When the aes-intel module is loaded on a system that does not have the
AES instructions, it prints

    Intel AES-NI instructions are not detected.

at level KERN_ERR.  Since aes-intel is aliased to "aes" it will be tried
whenever anything uses AES and spam the console.  This doesn't match
existing practice for how to handle "no hardware" when initializing a
module, so downgrade the message to KERN_INFO.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
 arch/x86/crypto/aesni-intel_glue.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/crypto/aesni-intel_glue.c b/arch/x86/crypto/aesni-intel_glue.c
index c580c5e..d3ec8d5 100644
--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -636,7 +636,7 @@ static int __init aesni_init(void)
 	int err;
 
 	if (!cpu_has_aes) {
-		printk(KERN_ERR "Intel AES-NI instructions are not detected.\n");
+		printk(KERN_INFO "Intel AES-NI instructions are not detected.\n");
 		return -ENODEV;
 	}
 	if ((err = crypto_register_alg(&aesni_alg)))

Re: [PATCH] crypto: aes-ni - Don't print message with KERN_ERR on old system

[Herbert Xu]

On Tue, Jun 23, 2009 at 10:20:16AM -0700, Roland Dreier wrote:
> When the aes-intel module is loaded on a system that does not have the
> AES instructions, it prints
> 
>     Intel AES-NI instructions are not detected.
> 
> at level KERN_ERR.  Since aes-intel is aliased to "aes" it will be tried
> whenever anything uses AES and spam the console.  This doesn't match
> existing practice for how to handle "no hardware" when initializing a
> module, so downgrade the message to KERN_INFO.
> 
> Signed-off-by: Roland Dreier <rolandd@cisco.com>

Patch applied.  Thanks Roland!
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt