Re: [PATCH] block: Fix register_disk() when name has '/' in it

Kay Sievers
2009-01-10T06:18:53Z

On Sat, Jan 10, 2009 at 07:11, Roland Dreier <rdreier@cisco.com> wrote:
> > > Commit 3ada8b7e ("block: struct device - replace bus_id with dev_name(),
> > > dev_set_name()") deleted the code in register_disk() that changed a '/'
> > > to a '!' in the device name when registering a disk.
> >
> > Hmm, this is done in the core, for all devices since a while:
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9f255651fb41c111ee35a2ae632df8ce9bd61def
> >
> > We should find what is going wrong here, instead of putting that code back.
>
> The commit you point to is for kobject_set_name() ... but dev_set_name()
> is still just setting dev->bus_id (at least in Linus's current tree).

Ah, right, it will only work after dev_name() returns the kobject
name, which it already does with the patches in our queue, so we
missed that. Sorry.

> If you want I can send a patch putting the conversion into
> dev_set_name() for now instead.

Sounds good, we can remove that with the final conversion and the
removal of the bus_id field.

Thanks,
Kay