From: Roland Dreier <rdreier@cisco.com>
To: Eric Anholt <eric@anholt.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Set up an MTRR covering the GTT at driver load.
Date: Fri, 23 Jan 2009 15:13:46 -0800 [thread overview]
Message-ID: <adar62t1uqd.fsf@cisco.com> (raw)
In-Reply-To: <1232751258-32611-1-git-send-email-eric@anholt.net> (Eric Anholt's message of "Fri, 23 Jan 2009 14:54:17 -0800")
> + dev_priv->mm.gtt_mtrr = -1;
> + dev_priv->mm.gtt_mtrr = mtrr_add(dev->agp->base,
> + dev->agp->agp_info.aper_size *
> + 1024 * 1024,
> + MTRR_TYPE_WRCOMB, 1);
Two assignments to gtt_mtrr in a row looks a bit odd?
- R.
next prev parent reply other threads:[~2009-01-23 23:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 22:54 [PATCH] drm/i915: Set up an MTRR covering the GTT at driver load Eric Anholt
2009-01-23 22:54 ` [PATCH] x86: Work around PAGE_KERNEL_WC not getting WC in iomap_atomic_prot_pfn Eric Anholt
2009-01-23 23:15 ` Roland Dreier
2009-01-23 23:29 ` Eric Anholt
2009-01-23 23:13 ` Roland Dreier [this message]
2009-01-24 11:51 ` [PATCH] drm/i915: Set up an MTRR covering the GTT at driver load Olivier Galibert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adar62t1uqd.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox