Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd()

Davide Libenzi
2008-02-27T20:31:13Z

On Wed, 27 Feb 2008, Roland Dreier wrote:

> > > The anonymous inodes interface anon_inode_getfd() calls fd_install()
> > > for the newly created fd, which does not work for some use cases where
> > > the caller must do futher initialization before exposing the file to
> > > userspace. This is also probably not the safest interface, since the
> > > caller must be sure that it is OK if userspace closes the fd before
> > > anon_inode_getfd() even returns.
> >
> > I believe Al changed the interface to not give out inode* and file*, *and*
> > call fd_install() inside it. I'd slightly prefer Al version, although I
> > don't see any major problems in this one too.
>
> Any pointer to that patch? A web search for "viro" and
> "anon_inode_getfd" doesn't turn up anything likely looking.

It's inside his vfs git tree:

http://git.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=commit;h=49be4f8114e6ff0efdab10ebba2493fb67bc3034

I'm fine with both approaches.

- Davide